[Bug 1169137] Review Request: nodejs-htmlparser2 - Fast & forgiving HTML/XML/RSS parser

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1169137

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---

Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-htmlparser2.noarch: W: only-non-binary-in-usr-lib
nodejs-htmlparser2.noarch: W: dangling-symlink
/usr/lib/node_modules/htmlparser2/node_modules/entities
/usr/lib/node_modules/entities
nodejs-htmlparser2.noarch: W: dangling-symlink
/usr/lib/node_modules/htmlparser2/node_modules/domutils
/usr/lib/node_modules/domutils
nodejs-htmlparser2.noarch: W: dangling-symlink
/usr/lib/node_modules/htmlparser2/node_modules/domelementtype
/usr/lib/node_modules/domelementtype
nodejs-htmlparser2.noarch: W: dangling-symlink
/usr/lib/node_modules/htmlparser2/node_modules/readable-stream
/usr/lib/node_modules/readable-stream
nodejs-htmlparser2.noarch: W: dangling-symlink
/usr/lib/node_modules/htmlparser2/node_modules/domhandler
/usr/lib/node_modules/domhandler
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: a590cb45b58657bb4f921318d3658aed8a5d2fdaf795e24d5219ff7833d59c83
upstream tarball: 
a590cb45b58657bb4f921318d3658aed8a5d2fdaf795e24d5219ff7833d59c83

+ License is "MIT" and included in its own LICENCE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) Group tag is optional, can be removed

2) rm -rf node_modules in %prep needed

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component