[Bug 1176307] Review Request: torrent-file-editor - Qt based GUI tool designed to create and edit .torrent files

Sun Dec 21 17:46:05 UTC 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1176307

--- Comment #4 from Raphael Groner <projects.rg at smart.ms> ---
Issues:
=======

- delete some files in %prep section, they are obviously not needed for a
Fedora package, licensecheck says:
Unknown or generated
--------------------
torrent-file-editor-0.1.0/.project.el
torrent-file-editor-0.1.0/build-nsis.sh
torrent-file-editor-0.1.0/build.sh
(also the MacOS* file(s) could be removed to not come in the way somehow)

- gtk-update-icon-cache is invoked in %postun and %posttrans if package
  contains icons.
  Note: icons in torrent-file-editor
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
===> use also the %posttrans section for gtk-update-icon-cache, is there any
reason to not do here?

- update-desktop-database is invoked in %post and %postun if package contains
  desktop file(s) with a MimeType: entry.
  Note: desktop file(s) with MimeType entry in torrent-file-editor
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
  database

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL (v3 or later)", "Unknown or generated". 3 files have unknown
     license. Detailed output of licensecheck in /home/build/fedora-
     review/1176307-torrent-file-editor/licensecheck.txt
===> Please remove those files without any license cause not needed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[?]: Sources contain only permissible code or content.
===> Where do you (as upstream) have all the icons from? Are those GPL'ed?
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
     file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.

Rpmlint
-------
Checking: torrent-file-editor-0.1.0-2.fc22.x86_64.rpm
          torrent-file-editor-0.1.0-2.fc22.src.rpm
torrent-file-editor.x86_64: W: spelling-error %description -l en_US codings ->
coding, comings, copings
torrent-file-editor.x86_64: W: no-manual-page-for-binary torrent-file-editor
torrent-file-editor.src: W: spelling-error %description -l en_US codings ->
coding, comings, copings
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

===> OK

Rpmlint (installed packages)
----------------------------
# rpmlint torrent-file-editor
torrent-file-editor.x86_64: W: spelling-error %description -l en_US codings ->
coding, comings, copings
torrent-file-editor.x86_64: W: no-manual-page-for-binary torrent-file-editor
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
# echo 'rpmlint-done:'

===> OK

Requires
--------
torrent-file-editor (rpmlib, GLIBC filtered):
    /bin/sh
    hicolor-icon-theme
    libQtCore.so.4()(64bit)
    libQtGui.so.4()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libqjson.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

Provides
--------
torrent-file-editor:
    application()
    application(torrent-file-editor.desktop)
    mimehandler(application/x-bittorrent)
    torrent-file-editor
    torrent-file-editor(x86-64)

Source checksums
----------------
http://downloads.sourceforge.net/torrent-file-editor/torrent-file-editor-0.1.0.tar.gz
:
  CHECKSUM(SHA256) this package     :
250a4da24f110b27d7652feb7a10079917372bb4bd9b20886f561c0a2865a8f2
  CHECKSUM(SHA256) upstream package :
250a4da24f110b27d7652feb7a10079917372bb4bd9b20886f561c0a2865a8f2

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 --verbose -b 1176307
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component