[Bug 1176277] Review Request: Shinobi - Meta build system for Ninja

Mon Dec 22 12:36:50 UTC 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1176277

--- Comment #6 from Ivan Romanov <drizt at land.ru> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- All build dependencies are listed in BuildRequires, except for any that are
  listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: diffutils
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 6 files have unknown license. Detailed output of
     licensecheck in /home/taurus/1176277-Shinobi/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: Shinobi-0.9-2.fc22.x86_64.rpm
          Shinobi-0.9-2.fc22.src.rpm
Shinobi.x86_64: W: spelling-error %description -l en_US qmake -> make, quake, q
make
Shinobi.x86_64: W: spelling-error %description -l en_US cpp -> cop, pp, cps
Shinobi.x86_64: W: spelling-error %description -l en_US cxx -> xxx, xx, cox
Shinobi.x86_64: W: no-manual-page-for-binary shinobi
Shinobi.src: W: spelling-error %description -l en_US qmake -> make, quake, q
make
Shinobi.src: W: spelling-error %description -l en_US cpp -> cop, pp, cps
Shinobi.src: W: spelling-error %description -l en_US cxx -> xxx, xx, cox
Shinobi.src:24: W: unversioned-explicit-provides %{binary}
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

Rpmlint (installed packages)
----------------------------
# rpmlint Shinobi
Shinobi.x86_64: W: spelling-error %description -l en_US qmake -> make, quake, q
make
Shinobi.x86_64: W: spelling-error %description -l en_US cpp -> cop, pp, cps
Shinobi.x86_64: W: spelling-error %description -l en_US cxx -> xxx, xx, cox
Shinobi.x86_64: W: no-manual-page-for-binary shinobi
1 packages and 0 specfiles checked; 0 errors, 4 warnings.
# echo 'rpmlint-done:'

Requires
--------
Shinobi (rpmlib, GLIBC filtered):
    boost-filesystem
    libboost_filesystem.so.1.55.0()(64bit)
    libboost_system.so.1.55.0()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libgcc_s.so.1(GCC_3.4)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.5)(64bit)
    rtld(GNU_HASH)

Provides
--------
Shinobi:
    Shinobi
    Shinobi(x86-64)
    shinobi

Source checksums
----------------
https://github.com/Rapptz/Shinobi/archive/v0.9.tar.gz#/Shinobi-0.9.tar.gz :
  CHECKSUM(SHA256) this package     :
105cd81e3c432c87656d7c04a94377b92990f594c3e7ab91fa6bdd26f0f67378
  CHECKSUM(SHA256) upstream package :
105cd81e3c432c87656d7c04a94377b92990f594c3e7ab91fa6bdd26f0f67378

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -b 1176277
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component