[Bug 1061801] Review Request: gmic - GREYC's Magic for Image Computing

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1061801



--- Comment #5 from Daniel Berrange <berrange at redhat.com> ---
Refreshed packages

SRPM URL:
http://berrange.fedorapeople.org/review/gmic/gmic-1.5.8.3-2.fc20.src.rpm
Spec URL: http://berrange.fedorapeople.org/review/gmic/gmic.spec

(In reply to Christopher Meng from comment #3)
> Please package newer version 1.5.8.3 released 16 hours ago...... XDDD

Done

> 1. All subpackages has Requires: %{name} = %{version}-%{release} but
> 
> Missing %?_isa need to be appended after %{name}.

Added to the -devel RPM. I actually removed the Requires from the plugin + zart
RPMs since they're not needed for the apps to operate afaict

> 2. devel package template:

Done

> 3. Being as the Design softwares SIG leader, I'd say that gimp plugins need
> to be named as gimp-%{name}-plugin.

Done

> 4. make in subdirectory? Just try make -C $(SUBDIRECTORY) --> 

Done

> 5. You may need to add a %configure : || in %build also for LDFLAGS since
> this package doesn't use configure to honor global ldflags.

Setting OPT_LDFLAGS appears sufficient to make it honour global ldflags

> 6. No %defattr(-,root,root) please.

Done

> 7. No zart build. Please use %package -n zart to create a separate package.

Done - missed that the rules in src/Makefile had disabled zart !

> 8. %{_prefix}/include --> %{_includedir}

Done

> 9. Add lang(fr):

Done

> 10. Delete Buildroot: %{_tmppath}/%{name}-%{version}-root

Done

> 11. I guess your spec is copied from somewhere(whole build process doesn't
> require qt4), no problem, just build zart. But one note is that Fedora has
> %qmake_qt4 macro to build, so if normal build is not perfect(e.g no inserted
> ldflags from fedora system), please manually build it.

The %qmake_qt4 macro did not appear to work with zart - a normal make was
succesful though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component