[Bug 1064455] Review Request: godot-engine - A fully featured open-source game engine

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1064455



--- Comment #3 from Christopher Meng <cickumqt at gmail.com> ---
SCON is a buildsystem? IMO it's bullshit. If you have the power, please
persuade upstream to use CMake.

1. LDFLAGS not inserted, please take a look at %__global_ldflags

2. GODOT_BUILTIN_ZLIB=no
GODOT_DDS=no
GODOT_DEFAULT_GUI_THEME=yes
GODOT_DISABLE_3D=no
GODOT_DISABLE_ADVANCED_GUI=no
GODOT_FREETYPE=yes
GODOT_JPEG=yes
GODOT_LUA=no
GODOT_MINIZIP=yes
GODOT_MUSEPACK=yes
GODOT_NEDMALLOC=yes
GODOT_OLD_SCENES=yes
GODOT_OPENGL=yes
GODOT_PNG=yes
GODOT_PVR=yes
GODOT_PYTHON=no
GODOT_SCRIPT=yes
GODOT_SPEEX=yes
GODOT_SQUIRREL=no
GODOT_SQUISH=no
GODOT_THEORA=yes
GODOT_TOOLS=yes
GODOT_VORBIS=yes
GODOT_WEBP=yes
GODOT_XML=yes

Any explanation of the no items?

3. Bundled code should be rm -rf to ensure the purity, but I haven't tested if
it will make scon become a brat.

4. install -m 0755 -d %{buildroot}/%{_docdir}/%{name}
install -m 0755 -d %{buildroot}/%{_bindir}
install -m 0755 ./bin/godot_rel %{buildroot}/%{_bindir}/godot
install -m 0755 ./bin/godot_server %{buildroot}/%{_bindir}/godot_server

No slash between %buildroot and other macros;
No -p option to preserve the timestamp;
Why did you mkdir the %_pkgdocdir? And then %doc in %files with nothing?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component