[Bug 1024779] Review Request: roger-router - Roger router manager for FRITZ!Box and compatible routers

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1024779



--- Comment #6 from Louis Lagendijk <louis at lagendijk.xs4all.nl> ---
Thanks for the feedback Christopher,
Re 1. First question, do we need to follow SUSE's way of handling plugins? I
don't agree with the packaging here, one -plugins package is enough.

I moved a number of plugins into the main package. I left the evolution address
book as it has dependencies on all the evolution libs, I wanted to avoid havng
to pull in all that stuff when not required.
I am fine with pulling all the notification plugins into the main package. The
status icon does not work on Gnome 3, so it might be better to keep that
separate too and explain the reason why.

I started off from the Suse spec file, but redid it, so the resemblance to the
Suse spec is mainly gone anyhow

Re If I ask you to write a SPEC from scratch, will you split out the library
libroutermanager?

You mean make libroutermanager its own package and have both libroutermanager
and roger-router packages build from the same tar-ball? What is the advantage
of that? They are both in the same tar-ball, so keeping it this way is less
work in maintaining the packages. I have started a discussion with upstream on
properly versioning libroutermanager-libs. That will hopefully come in the near
future.

Re 2 - 6 Will check and fix

Re 7: yes: 78 is defined in //usr/share/doc/setup/uidgid as the predefined gid
for fax. Is there anything wrong with re-using that gid?

Re 8: will check if this can be easily done. I left this as I did not want to
deviate from what upstream uses. If you feel that it is incorrect I can modify
the upstream Makefile.am to skip the plugin specific directories. But is it
worth changing the upstream defaults?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component