[Bug 1065306] Review Request: pyxtrlock - The X transparent screen lock rewritten in Python

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1065306

Christopher Meng <cickumqt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #8 from Christopher Meng <cickumqt at gmail.com> ---
Writing license header is a good habit, not a must-have.

Also forgot this:

cp %{SOURCE1} %{buildroot}%{_datadir}/pixmaps/

You Ruthie can add -a option to preserve the timestamp, or use install -pm644
to install it with timestamp preserved and permission correctly set. Your
choice here. 

Finally hope you can ship desktop file and icon in the git repo(tarball).

Hint: my internal project use setup.py to install it directly, but I will use
desktop-file-validate to validate itself. Your choice again. (I can submit a
patch to github if you want)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component