[Bug 1066029] Review Request: csmock - A mock wrapper for Static Analysis tools

Tue Feb 25 04:37:31 UTC 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1066029

Christopher Meng <cickumqt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|                            |fedora-review?

--- Comment #6 from Christopher Meng <cickumqt at gmail.com> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "GPL". Detailed output of licensecheck:

GPL
---
csmock-1.0.3/make-srpm.sh

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 40960 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint

Installation errors
-------------------
INFO: mock.py version 1.1.36 starting...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
Start: run
Mock Version: 1.1.36
INFO: Mock Version: 1.1.36
Start: lock buildroot
INFO: installing package(s):
/home/rpmaker/Desktop/csmock/results/csmock-1.0.3-1.fc21.noarch.rpm
ERROR: Command failed: 
 # ['/usr/bin/yum', '--installroot', '/var/lib/mock/fedora-rawhide-i386/root/',
'--releasever', '21', 'install',
'/home/rpmaker/Desktop/csmock/results/csmock-1.0.3-1.fc21.noarch.rpm',
'--setopt=tsflags=nocontexts']
Error: Package: csmock-1.0.3-1.fc21.noarch (/csmock-1.0.3-1.fc21.noarch)
           Requires: cscppc
 You could try using --skip-broken to work around the problem
Error: Package: csmock-1.0.3-1.fc21.noarch (/csmock-1.0.3-1.fc21.noarch)
           Requires: cswrap
Error: Package: csmock-1.0.3-1.fc21.noarch (/csmock-1.0.3-1.fc21.noarch)
           Requires: csdiff
 You could try running: rpm -Va --nofiles --nodigest

Rpmlint
-------
Checking: csmock-1.0.3-1.fc21.noarch.rpm
          csmock-1.0.3-1.fc21.src.rpm
csmock.noarch: W: spelling-error %description -l en_US cov -> cob, co, cove
csmock.noarch: W: spelling-error %description -l en_US mockbuild -> mock build,
mock-build, mockingbird
csmock.noarch: W: spelling-error %description -l en_US diffbuild -> diff build,
diff-build, building
csmock.noarch: W: no-manual-page-for-binary cov-dump-err
csmock.noarch: W: no-manual-page-for-binary rpmbuild-rawbuild
csmock.src: W: spelling-error %description -l en_US cov -> cob, co, cove
csmock.src: W: spelling-error %description -l en_US mockbuild -> mock build,
mock-build, mockingbird
csmock.src: W: spelling-error %description -l en_US diffbuild -> diff build,
diff-build, building
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

Requires
--------
csmock (rpmlib, GLIBC filtered):
    /bin/bash
    /usr/bin/perl
    cscppc
    csdiff
    cswrap
    mock
    perl(Getopt::Std)
    perl(strict)
    perl(warnings)
    rpm-build

Provides
--------
csmock:
    csmock

Source checksums
----------------
https://git.fedorahosted.org/cgit/csmock.git/snapshot/csmock-1.0.3.tar.xz :
  CHECKSUM(SHA256) this package     :
06a34529645103e1c2aae0705c7377d4e578a161e747e957927b2aa229f7884f
  CHECKSUM(SHA256) upstream package :
06a34529645103e1c2aae0705c7377d4e578a161e747e957927b2aa229f7884f

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rvn csmock-1.0.3-1.el6.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

---------------------------
1. Source0:   
https://git.fedorahosted.org/cgit/csmock.git/snapshot/csmock-1.0.3.tar.xz

Suggestion for the future working in scm:

Source0:   
https://git.fedorahosted.org/cgit/csmock.git/snapshot/csmock-%{version}.tar.xz

2. sed -e 's/rpm -qf .SELF/echo %{version}/' -i bin/cov-{diff,mock}build

You can do this in %prep, dunno why you did that in %build.

3. install -p to preserve the timestamp.

Please fix above. I will approve the package once the requires are packaged
into pkgdb.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component