[Bug 1068747] Review Request: birdie - A twitter client for Linux

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1068747



--- Comment #26 from Ryan Lerch <rlerch at redhat.com> ---
(In reply to Mukundan Ragavan from comment #22)
> Ryan, That looks good. I think almost everything is done. Just a couple of
> minor issues and then I think it's done.
> 
> [ ]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/locale/sr_RS at latin/LC_MESSAGES,
>      /usr/share/indicators, /usr/share/indicators/messages,
>      /usr/share/locale/sr_RS at latin,
>      /usr/share/indicators/messages/applications
> 
> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/indicators,
>      /usr/share/locale/sr_RS at latin,
>      /usr/share/indicators/messages/applications, /usr/share/appdata,
>      /usr/share/locale/sr_RS at latin/LC_MESSAGES,
> /usr/share/indicators/messages
> 
> Here, based on my discussion on #fedora-devel, we can ignore the messages
> about the locales since these should be owned by the filesystem.
> 
> The package must own /usr/share/indicators.
> 
> So, add in %files section
> 
> %{_datadir}/indicators/*
> 
> instead of /usr/share/indicators/messages/applications/birdie so that the
> directory is owned by the package.
> 
> Based on -
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#The_directory_is_wholly_contained_in_your_package.
> 2C_or_involves_core_functionality_of_your_package
> 
> I believe that should be it. 
> 
> If you could please fix that, upload the spec and srpm (link is broken), I
> can run fedora-review again (just in case) and approve the package.

Thanks, Updated and pushed to my git repo here. 
https://github.com/ryanlerch/my-fedora-package-reviews/commit/b85b072fea776ff597f50219d5b20025acea9510

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component