[Bug 1026764] Review Request: uhttpmock - HTTP web service mocking library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1026764

Cole Robinson <crobinso at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |crobinso at redhat.com
           Assignee|nobody at fedoraproject.org    |crobinso at redhat.com



--- Comment #4 from Cole Robinson <crobinso at redhat.com> ---
Unless you are planning on building for EPEL, you can drop the Group: tags:

https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag


rpmlint gives:

uhttpmock.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libuhttpmock-0.0.so.0.0.1 /lib64/libgthread-2.0.so.0
uhttpmock.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libuhttpmock-0.0.so.0.0.1 /lib64/libpthread.so.0

'git grep gthread' and some poking seems to show that gthread doesn't appear to
be used at all, except in configure and the pkgconfig file. (I might be missing
something though, not too savvy here)


Mark the gtk-doc bits with %doc


It seems inconsistent to use explicit file listing like:

%{_datadir}/vala/vapi/libuhttpmock-%{uhm_api_version}.dep

Mixed with wildcards like:

%{_libdir}/*.so

I'd recommend to standardize on using all explicit paths.


It appears the package has tests, consider running them in a %check section if
it's safe to do so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component