[Bug 1070449] Review Request: sediment - A code reorder tool to improve memory hierarchy performance

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1070449



--- Comment #4 from Christopher Meng <cickumqt at gmail.com> ---
(In reply to William Cohen from comment #2)
> Thanks for the comments.
> 
> I have incorporated the #1 and #3 from comment 1.  I am doing the
> development work on f19 and there is a chance that this package could be
> used in the future in RHEL7 which is f19 based, so #2 is left as is to allow
> it build on f19 and RHEL7.

#2 %{_datadir}/doc --> %{_docdir}

PASSED.
------------------

1. sediment.noarch: E: script-without-shebang
/usr/libexec/sediment/write-dot-callgraph.py

Requires
--------
sediment (rpmlib, GLIBC filtered):
    /usr/bin/env
    graphviz-python



Provides
--------
sediment:
    sediment

Patch env to absolute path like %{__python2}.

------------------

[?]: %check is present and all tests pass. Maybe you can finish it in the
future, not a blocker.

------------------

- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/doc/sediment/html
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

------------------

GPL (v3 or later)
-----------------
sediment-0.5/write-dot-callgraph.py

Unknown or generated
--------------------
sediment-0.5/docs/conf.py

PASSED.
-------------------

Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rvn sediment-0.5-1.fc19.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

------------------------------
Provide me the new spec/srpm. Then I will approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component