[Bug 1047596] Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1047596



--- Comment #3 from Adam Williamson <awilliam at redhat.com> ---
"version have no sense for such package, but we are used to take the rest
version"

ah, OK, I took the 'version' from the .xml file.

"minimal version have no more sense (RHEL-4 is EOL)"

cargo culted from the other specs :)

"mixed-use-of-spaces-and-tabs"

more cargo culting...

"As this channel provides a lot of extensions which already exists in standard
pear channel (probably all are not packaged) we should be very carefull with
each package, to check file conflicts, in peardir, docdir, ..."

We don't actually have much php crypt stuff packaged that I can see. I did
check for conflicts other than Blowfish and didn't see any, but a double check
would be welcome indeed.

"A possible solution could be to set a specific pear_phpdir, pear_docdir,
pear_testdir... for this channel (so in the %post of this package). but I hope
this is not required and we can go without."

Yeah, that was more or less my feeling - might be necessary, but let's hope
not.

I'll fix the things noted on import, thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component