[Bug 1048667] Review Request: docker-py - An API client for docker written in Python

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1048667

Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkabrda at redhat.com



--- Comment #2 from Bohuslav "Slavek" Kabrda <bkabrda at redhat.com> ---
Few fly-by comments (I can take the full review if that's ok with you, I really
want this package in Fedora):
- You should consider running tests in %check section during build.
- Why is there only the -devel package? It doesn't make any sense to me. Why
not keep everything in the main package?
- You have many BuildRequires for python packages, but no Requires (runtime
deps) for those. Why? Are they not needed? It doesn't seem so.
- Could you please consider adding python3- subpackage?
- AFAIK it'd be best to use PyPI as upstream [1], since it provides nice urls
and source archive that is actually named "docker-py-0.2.3.tar.gz" (whereas the
one from GH is named only "0.2.3.tar.gz").
- You should name the package python-docker-py. This naming convention was
agreed on at [2].
- Unless you want to build this for epel, please drop the %defattr line from
%files, it's not needed for Fedora anymore.
- It seems to me that the package doesn't actually own %{python_sitelib}/docker
directory.

[1] https://pypi.python.org/pypi/docker-py
[2] https://fedorahosted.org/fpc/ticket/271

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component