[Bug 1049557] Review Request: jpeginfo - Utility to obtain information from JPEG files

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1049557



--- Comment #4 from Denis Fateyev <denis at fateyev.com> ---
Igor, thanks for reviewing.

>If you don't want to package it for EL5 - drop it.

That's made intentionally since among other systems I'm planning to provide it
for EPEL5. All el5-related stuff wrapped into conditionals.

> %defattr(-,root,root,-)
> Not needed since F18 or older.

Same here - I left that also for Fedora since it doesn't break things.

> Why you using this? why not %make_install, which identical to 
> make install DESTDIR=%{buildroot} ?

Unfortunately, "make install" (and aliases) doen't work properly with the
package due some vagueness in Makefile. I preferred to pick the needed things
up to place them into the right location manually instead of patching Makefile.

> Please remove getopt sources in prep section (for innocence)

Didn't get that, sorry. Could you provide more details?

> Fix incorrect FSF address in files COPIYNG, COPYRIGHT
> Add Public Domain License to Licese-tag

It's licensed under GPLv2 or later, cannot be considered as Public Domain ;-)
As for the "incorrect FSF postal address", I really doubt it's an issue here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component