[Bug 1048460] Review Request: hawaii-shell - Hawaii shell for desktop, netbook and tablet

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1048460

Lukas Bezdicka <255993 at mail.muni.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #11 from Lukas Bezdicka <255993 at mail.muni.cz> ---
[/] - Package meets naming and packaging guidelines
[/] - Spec file matches base package name.
[/] - Spec has consistant macro usage.
[/] - Meets Packaging Guidelines.
BSD and LGPLv2+ and GPLv2+ - License
[/] - License field in spec matches
[/] - License file included in package - %doc
[/] - Spec in American English
[/] - Spec is legible.
[/] - Sources match upstream md5sum:

[X] - Package needs ExcludeArch
[?] - BuildRequires correct
[X] - Spec handles locales/find_lang
[X] - Package is relocatable and has a reason to be.
[X] - Package has %defattr and permissions on files is good.


[X] - Headers/static libs in -devel subpackage.
[X] - Spec has needed ldconfig in post and postun
[X] - .pc files in -devel subpackage/requires pkgconfig
[X] - .so files in -devel subpackage.
[X] - -devel package Requires: %{name} = %{version}-%{release}
[X] - .la files are removed.

[X] - Package is a GUI app and has a .desktop file

[/] - Package compiles and builds on at least one arch.
[/] - Package has no duplicate files in %files.
[/] - Package doesn't own any directories other packages own.
[/] - Package owns all the directories it creates.
[/] - No rpmlint output.
- final provides and requires are sane:
(include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =;
rpm -qp --requires $i; echo; done
manually indented after checking each line.  I also remove the rpmlib junk and
anything provided by glibc.)

SHOULD Items:

[/] - Should build in mock. - built in mock linked in ticket
[/] - Should build on all supported archs
[?] - Should function as described. - does not work here at all
[/] - Should have sane scriptlets.
[/] - Should have subpackages require base package with fully versioned depend.
[/] - Should have dist tag
[/] - Should package latest version
[/] - check for outstanding bugs on package. (For core merge reviews)

Issues:

1. Except that it does not build here but I can see your mock build I would say
fine. Well at least for package that does not run.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component