[Bug 970405] Review Request: mingw-speex - A voice compression format (codec)

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=970405

František Dvořák <valtri at civ.zcu.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ulatekh at yahoo.com,
                   |                            |valtri at civ.zcu.cz
              Flags|                            |needinfo?(ulatekh at yahoo.com
                   |                            |)



--- Comment #2 from František Dvořák <valtri at civ.zcu.cz> ---
Steve, do you plan to continue on the work on mingw-speex? It looks like there
is no response more than one month and this review can be closed as dead review
(http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews).


Found issues: (no problem is critical, but 1) and 4) is checked by rpmlint)

1) as mentioned by Veaceslav: Group, %clean, %defattr and 'rm -f' in %install
are not needed

2) manual.pdf and manual pages are not needed (already in the native package),
NEWS and TODO could be removed too

3) dependencies:
 - BuildRequire: is MinGW gcc-c++ needed? binutils can be removed ("inherited"
by gcc)
 - Requires: pkgconfig not needed - it is used only on base package, on real
mingw32/64 subpackages there should be mingw32/64 version of pkgconfig anyway
and it is autogenerated

4) cosmetic: mixed spaces and tabs

5) descriptions could be reformatted/unified

6) cosmetic: combining %exclude (for .la) and 'rm -f' (for manual.pdf)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component