[Bug 1059281] Review Request: monitoring-plugins - Host/service/network monitoring program plugins for a variety of different systems

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1059281



--- Comment #1 from Michael Scherer <misc at zarb.org> ---
So :
- the list on Requires on 1 single line is a bit too long for my taste, 1
requires per line would likely be better in diff, etc. And it would also be
better to have precise requires ( ie, on the specific version )

- the requires on the -log subpackage :
Requires: /bin/egrep

any reason to not use %{_bindir}/ like the rest ?

- description could be enhanced to say this provides more than plugin for
nagios 

- %{_libdir}/monitoring/ is unowned

- the various setuid plugin are not a good ideas IMHO, not sure if that
requires FESCO approval or something. I would feel better if this was using
capacity.

- I see a few tests for the plugins and the lib, yet no %check, is this normal
?

- there is a few tarballs of perl source code, but this is not used for now,
just mentioning for documenting it

- why do all plugin provides monitoring-plugins ? ( and not a requires ? )

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component