[Bug 1069243] Review Request: ccaudio2 - C++ class framework for telephonic audio applications
bugzilla at redhat.com
bugzilla at redhat.com
Thu Jul 3 17:18:53 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1069243
--- Comment #21 from Christopher Meng <i at cicku.me> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later) (with incorrect FSF address)", "LGPL (v3 or later)",
"GPL (v2 or later)", "Unknown or generated". 4 files have unknown
license. Detailed output of licensecheck:
GPL (v2 or later)
-----------------
ccaudio2-2.1.2/autoconf/ltmain.sh
GPL (v2 or later) (with incorrect FSF address)
----------------------------------------------
ccaudio2-2.1.2/src/osx.cpp
LGPL (v3 or later)
------------------
ccaudio2-2.1.2/inc/ccaudio2.h
ccaudio2-2.1.2/src/audiobase.cpp
ccaudio2-2.1.2/src/audiobuffer.cpp
ccaudio2-2.1.2/src/audiofile.cpp
ccaudio2-2.1.2/src/codec.cpp
ccaudio2-2.1.2/src/dialers.cpp
ccaudio2-2.1.2/src/fileio.cpp
ccaudio2-2.1.2/src/friends.cpp
ccaudio2-2.1.2/src/mapper.cpp
ccaudio2-2.1.2/src/oss.cpp
ccaudio2-2.1.2/src/resample.cpp
ccaudio2-2.1.2/src/stream.cpp
ccaudio2-2.1.2/src/teltones.cpp
ccaudio2-2.1.2/src/tone.cpp
ccaudio2-2.1.2/src/w32.cpp
ccaudio2-2.1.2/utils/audiotool.cpp
ccaudio2-2.1.2/utils/tonetool.cpp
Unknown or generated
--------------------
ccaudio2-2.1.2/autogen.sh
ccaudio2-2.1.2/cmake-abi.sh
ccaudio2-2.1.2/cmodel.sh
ccaudio2-2.1.2/src/detect.cpp
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: Sources can be downloaded from URI in Source: tag
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Rpmlint
-------
Checking: ccaudio2-2.1.2-1.fc21.i686.rpm
ccaudio2-bin-2.1.2-1.fc21.i686.rpm
ccaudio2-devel-2.1.2-1.fc21.i686.rpm
ccaudio2-2.1.2-1.fc21.src.rpm
ccaudio2.i686: W: spelling-error %description -l en_US transcoding -> trans
coding, trans-coding, transcending
ccaudio2-devel.i686: W: spelling-error %description -l en_US ccAudio -> cc
Audio, cc-audio, Claudio
ccaudio2-devel.i686: W: no-documentation
ccaudio2.src: W: spelling-error %description -l en_US transcoding -> trans
coding, trans-coding, transcending
ccaudio2.src: W: invalid-url Source0:
http://dev.gnutelephony.org/dist/tarballs/ccaudio2-2.1.2.tar.gz HTTP Error 404:
Not Found
4 packages and 0 specfiles checked; 0 errors, 5 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint ccaudio2 ccaudio2-bin ccaudio2-devel
ccaudio2.i686: W: spelling-error %description -l en_US transcoding -> trans
coding, trans-coding, transcending
ccaudio2.i686: W: unused-direct-shlib-dependency /usr/lib/libccaudio2.so.2.0.2
/lib/libusecure.so.6
ccaudio2.i686: W: unused-direct-shlib-dependency /usr/lib/libccaudio2.so.2.0.2
/lib/libssl.so.10
ccaudio2.i686: W: unused-direct-shlib-dependency /usr/lib/libccaudio2.so.2.0.2
/lib/libcrypto.so.10
ccaudio2.i686: W: unused-direct-shlib-dependency /usr/lib/libccaudio2.so.2.0.2
/lib/libdl.so.2
ccaudio2.i686: W: unused-direct-shlib-dependency /usr/lib/libccaudio2.so.2.0.2
/lib/librt.so.1
ccaudio2-devel.i686: W: spelling-error %description -l en_US ccAudio -> cc
Audio, cc-audio, Claudio
ccaudio2-devel.i686: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
# echo 'rpmlint-done:'
Requires
--------
ccaudio2 (rpmlib, GLIBC filtered):
/sbin/ldconfig
config(ccaudio2)
libc.so.6
libcrypto.so.10
libdl.so.2
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgsm.so.1
libm.so.6
libpthread.so.0
librt.so.1
libspeex.so.1
libssl.so.10
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libucommon.so.6
libusecure.so.6
rtld(GNU_HASH)
ccaudio2-bin (rpmlib, GLIBC filtered):
ccaudio2(x86-32)
libc.so.6
libccaudio2.so.2
libcrypto.so.10
libdl.so.2
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgsm.so.1
libm.so.6
libpthread.so.0
librt.so.1
libspeex.so.1
libssl.so.10
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libucommon.so.6
libusecure.so.6
rtld(GNU_HASH)
ccaudio2-devel (rpmlib, GLIBC filtered):
/usr/bin/pkg-config
ccaudio2(x86-32)
libccaudio2.so.2
pkgconfig(ucommon)
ucommon-devel(x86-32)
Provides
--------
ccaudio2:
ccaudio2
ccaudio2(x86-32)
config(ccaudio2)
libccaudio2.so.2
ccaudio2-bin:
ccaudio2-bin
ccaudio2-bin(x86-32)
ccaudio2-devel:
ccaudio2-devel
ccaudio2-devel(x86-32)
pkgconfig(ccaudio2)
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -rvn ccaudio2-2.1.2-1.fc21.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
--------------------------------------------
1. Fix rpmlint issues about the unused direct shared lib dep.
2. Rename -bin to -utils.
3. Seems that the build is hidden, is it possible for you to turn the hidden
off and display the compiler flags instead of "Building CXX object..."?
Others are fine.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list