[Bug 1118740] Review Request: fakesystemd - Minimal docker-specific package to satisfy systemd Provides

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1118740

Matthew Miller <mattdm at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|nobody at fedoraproject.org    |mattdm at redhat.com



--- Comment #2 from Matthew Miller <mattdm at redhat.com> ---
I've got some pendantic things to clear up first.

1. Please make the summary shorter and the description longer, including a
gigantic warning not to install on a real system. And the summary shouldn't end
in a period. (I told you this was pedantic -- sorry!)

2. License says "GPL+", but no actual license text is included. Since this is
by nature minimal, what about using a much simpler license (like MIT -- maybe
https://fedoraproject.org/wiki/Licensing:MIT?rd=Licensing/MIT#Modern_Style_without_sublicense_.28Unicode.29)
and including the text directly in macros.systemd?

3. Since it conflicts with systemd, needs an explicit "Conflicts: systemd"

4. Copy in %prep stage is unnecessary (and in fact since you refer to
%{SOURCE0} directly later, it's not even doing anything

5. In %install stage, I think the big mkdir would be much easier to read and
maintain in 
   a loop, like:

for dir in systemd/system systemd/user tmpfiles.d sysctl.d modules-load.d
binfmt.d udev/rules.d
do
  mkdir -p %{buildroot}%{_sysconfdir}/${dir}
done

for dir in system-generators user-generators system-preset user-preset
system-shutdown system-sleep catalog ntp-units.d
do
  mkdir -p %{buildroot}%{_prefix}/lib/systemd/${dir}
done

for dir in tmpfiles.d sysctl.d sysctl.d modules-load.d binfmt.d
do
  mkdir -p %{buildroot}%{_prefix}/lib/${dir}
done



mkdir -p %{buildroot}%{_datadir}/systemd 
mkdir -p %{buildroot}%{_datadir}/pkgconfig
mkdir -p %{buildroot}%{_localstatedir}/lib/systemd/catalog

That's your call, but I think we'll be happier later. :)

An alternate approach would be to make a source tarball containing all of these
directories (along with the macro file), and just unpack it.

6. Can we get away with making this noarch?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component