[Bug 1119095] Review Request: python-djvulibre - Python bindings to DjVuLibre

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1119095



--- Comment #5 from Michel Alexandre Salim <michel at michel-slm.name> ---
Hi Brian,

Some notes regarding your latest revision -- the spec you link to is not the
spec used to build the SRPM, there's a typo in the latter.

Also you're using both %{buildroot} and $RPM_BUILD_ROOT -- you want to
consistently use one (doesn't matter which), and since you only use
$RPM_BUILD_ROOT twice (and the first, wiping the build root in %install, is
only needed if you plan to build for el5), I'd suggest sticking with buildroot.

cf
https://fedoraproject.org/wiki/EPEL:Packaging#Prepping_BuildRoot_For_.25install 

$ diff -u srpm/python-djvulibre.spec srpm-unpacked/python-djvulibre.spec
--- srpm/python-djvulibre.spec    2014-07-16 10:41:22.097479760 +0700
+++ srpm-unpacked/python-djvulibre.spec    2014-07-15 06:41:48.000000000 +0700
@@ -53,7 +53,7 @@
 rm -rf $RPM_BUILD_ROOT
 %{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT

-# Fix non-standard (0775) executable permissions on private shared libraries
+# Fix non-standard executable permissions on private shared libraries
 %{__chmod} 0755 %{buildroot}%{python2_sitearch}/djvu/sexpr.so
 %{__chmod} 0755 %{buildroot}%{python2_sitearch}/djvu/decode.so

@@ -66,7 +66,7 @@

 %changelog
 * Mon Jul 14 2014 Brian Stinson <bstinson at ksu.edu> - 0.3.9-2
-- Incorporate suggested macro removals and changes from jduncan and cicku
+- Incorporate suggested macro removals and changes from jducan and cicku

 * Sun Jul 13 2014 Brian Stinson <bstinson at ksu.edu> - 0.3.9-1
 - Initial Build

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component