[Bug 1115671] Review Request: nodejs-grunt-contrib-copy - Copy files and folders

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1115671

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review?



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ mock build is successful for f22

- rpmlint output on rpms gave
nodejs-grunt-contrib-copy.x86_64: E: no-binary
nodejs-grunt-contrib-copy.x86_64: W: only-non-binary-in-usr-lib
nodejs-grunt-contrib-copy-debuginfo.x86_64: E: empty-debuginfo-package
3 packages and 0 specfiles checked; 2 errors, 1 warnings.

==> See suggestion below

+ Source verified with upstream as (sha256sum)
srpm tarball    
:d3a1c5f78e17cc36adccc4e5b064c7772ccf4acb651295bc0da37cb31a1ce430
upstream tarball
:d3a1c5f78e17cc36adccc4e5b064c7772ccf4acb651295bc0da37cb31a1ce430

+ License "MIT" is valid and is included in its own file as %doc

+ rest looks following packaging guidelines


Suggestions:
1) Add following to spec
BuildArch:  noarch

%if 0%{?fedora} >= 19
ExclusiveArch:  %{nodejs_arches} noarch
%else
ExclusiveArch:  %{ix86} x86_64 %{arm} noarch
%endif

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component