[Bug 1120563] Review Request: php-ocramius-instantiator - Instantiate objects in PHP without invoking their constructors

bugzilla at redhat.com bugzilla at redhat.com
Mon Jul 21 00:35:49 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1120563

Shawn Iwinski <shawn.iwinski at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #4 from Shawn Iwinski <shawn.iwinski at gmail.com> ---
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
     Note: rm -rf %{buildroot} present but not required
[!]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[!]: Buildroot is not present
     Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required

As usual, remove after initial import.



[x]: Requires correct, justified where necessary.

     From phpcompatinfo:
         Requires: php-spl

Non-blocker because provided by php core.  Can be added after initial import.



No blockers.

===== APPROVED =====

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list