[Bug 1119087] Review Request: python-voluptuous - A Python data validation library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1119087



--- Comment #6 from Florian "der-flo" Lehner <dev at der-flo.net> ---
(In reply to Sergio Pascual from comment #5)
> Yes, this is a packaging error, I have reported it
> 
> https://github.com/alecthomas/voluptuous/issues/80 
> 
> I can use the zip from github instead. I will post a new spec

What about using the tarball from github?
Source0:       
http://github.com/alecthomas/voluptuous/archive/%{version}.tar.gz#/%{upname}-%{version}.tar.gz

> > > > [!]: Package consistently uses macros (instead of hard-coded directory
> > > > names).
> > > > 
> > > >    ---> Please replace rm with %{__rm} and cp with %{__install}
> > > > 
> > > 
> > > This guideline is a about directory names, not command names. If fact, from
> > > the guidelines:
> > > 
> > > Macro forms of system executables SHOULD NOT be used except when there is a
> > > need to allow the location of those executables to be configurable. For
> > > example, rm should be used in preference to %{__rm}, but %{__python} is
> > > acceptable.
> > 
> > Furthermore, it states:
> > Having macros in a Source: or Patch: line is a matter of style. Some people
> > enjoy the ready readability of a source line without macros. Others prefer
> > the ease of updating for new versions when macros are used.
> > 
> > And rpm --eval %{__rm} still works.
> > 
> 
> I do not follow you here.

Sorry! My mistake - you are right

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component