[Bug 1048493] Review Request: icecat - GNU version of Firefox browser
bugzilla at redhat.com
bugzilla at redhat.com
Mon Jul 21 22:05:26 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1048493
--- Comment #30 from Denis Fateyev <denis at fateyev.com> ---
Updated review for "icecat-24.0-10":
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
Note: Cannot find COPYING in rpm(s)
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- This seems like a Java package, please install fedora-review-plugin-java to
get additional checks
- Bundled jar/class files should be removed before build
Note: Jar files in source (see attachment)
See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
built_JAR_files_.2F_Other_bundled_software'
- Binary eggs must be removed in %prep
Note: Binary egg files not removed in %prep:
./python/virtualenv/virtualenv_support/setuptools-0.6c11-py2.5.egg
./python/virtualenv/virtualenv_support/setuptools-0.6c11-py2.7.egg
./python/virtualenv/virtualenv_support/setuptools-0.6c11-py2.6.egg
See:
http://fedoraproject.org/wiki/Packaging:Python#Packaging_eggs_and_setuptools_concerns
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"BSD (4 clause) ISC", "LGPL (v2.1 or later) (with incorrect FSF
address)", "BSD (3 clause) ISC", "*No copyright* MPL (v2.0)", "Apache
(v2.0) BSD (2 clause)", "*No copyright* BSD (3 clause)", "ISC", "*No
copyright* Apache (v2.0)", "Public domain", "GPL (v3 or later)", "BSD (2
clause)", "Apache (v2.0)", "GPL (v2 or later)", "*No copyright* Public
domain MPL (v2.0)", "MIT/X11 (BSD like)", "*No copyright* Public domain",
"BSD (3 clause)", "*No copyright* Beerware MPL (v2.0)", "LGPL (v2.1 or
later)", "MPL (v2.0) BSD (3 clause)", "LGPL", "Unknown or generated",
"BSD (4 clause)", "GPL", "*No copyright* GPL (v3 or later)", "BSD (3
clause) MIT/X11 (BSD like)", "MPL (v2.0) MIT/X11 (BSD like)", "Apache
(v2.0) MIT/X11 (BSD like)", "MPL (v2.0)", "MPL (v1.0) LGPL (v2 or later)
(with incorrect FSF address)", "MPL (v1.1) GPL (unversioned/unknown
version)", "MPL (v2.0) BSD (2 clause)". 1823 files have unknown license.
Detailed output of licensecheck in
/home/mock/sandbox/test/icecat/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in icecat
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in icecat
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 307200 bytes in 17 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Static libraries in -static or -devel subpackage, providing -devel if
present.
Note: Package has .a files: icecat-static.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Python eggs must not download any dependencies during the build process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[-]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
===== SHOULD items =====
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in icecat-
static
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: SourceX tarball generation or download is documented.
Note: Package contains tarball without URL, check comments
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Note: Arch-ed rpms have a total of 4536320 bytes in /usr/share
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: icecat-24.0-10.fc20.x86_64.rpm
icecat-devel-24.0-10.fc20.x86_64.rpm
icecat-static-24.0-10.fc20.x86_64.rpm
icecat-24.0-10.fc20.src.rpm
icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/icecat
['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/icecat-bin ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/mozilla-xremote-client ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/components/libmozgnome.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/browser/components/libbrowsercomps.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libmozalloc.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/components/libdbusservice.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libxul.so ['%{mozappdir}']
icecat.x86_64: E: missing-call-to-setgroups /usr/lib64/icecat-24.0/libxul.so
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/xulrunner-stub ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/webapprt-stub ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/plugin-container ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/xulrunner ['%{mozappdir}']
icecat.x86_64: E: incorrect-fsf-address
/usr/lib64/icecat-24.0/browser/extensions/https-everywhere at eff.org/chrome/content/code/NSS.js
icecat.x86_64: W: no-manual-page-for-binary icecat
icecat.x86_64: W: desktopfile-without-binary
/usr/share/applications/icecat-24.0.desktop icecat
icecat-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-devel-24.0/sdk/bin/xpcshell ['%{mozappdir}']
icecat-devel.x86_64: W: no-documentation
icecat-devel.x86_64: E: script-without-shebang
/usr/lib64/icecat-devel-24.0/sdk/bin/xpidllex.py
icecat-devel.x86_64: W: dangling-symlink /usr/lib64/icecat-devel-24.0/bin
/usr/lib64/icecat-24.0
icecat-devel.x86_64: E: script-without-shebang
/usr/lib64/icecat-devel-24.0/sdk/bin/xpidlyacc.py
icecat.src: W: %ifarch-applied-patch Patch1: %{name}-disable-neon.patch
icecat.src: W: invalid-url Source4: icecat-langpacks.tar.gz
4 packages and 0 specfiles checked; 17 errors, 6 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint icecat-devel icecat-static icecat
icecat-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-devel-24.0/sdk/bin/xpcshell ['%{mozappdir}']
icecat-devel.x86_64: W: no-documentation
icecat-devel.x86_64: E: script-without-shebang
/usr/lib64/icecat-devel-24.0/sdk/bin/xpidllex.py
icecat-devel.x86_64: W: dangling-symlink /usr/lib64/icecat-devel-24.0/bin
/usr/lib64/icecat-24.0
icecat-devel.x86_64: E: script-without-shebang
/usr/lib64/icecat-devel-24.0/sdk/bin/xpidlyacc.py
icecat.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/icecat-24.0/icecat
['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/icecat-bin ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/mozilla-xremote-client ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/components/libmozgnome.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/browser/components/libbrowsercomps.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libmozalloc.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/components/libdbusservice.so ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/libxul.so ['%{mozappdir}']
icecat.x86_64: E: missing-call-to-setgroups /usr/lib64/icecat-24.0/libxul.so
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/xulrunner-stub ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/webapprt-stub ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/plugin-container ['%{mozappdir}']
icecat.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/icecat-24.0/xulrunner ['%{mozappdir}']
icecat.x86_64: E: incorrect-fsf-address
/usr/lib64/icecat-24.0/browser/extensions/https-everywhere at eff.org/chrome/content/code/NSS.js
icecat.x86_64: W: no-manual-page-for-binary icecat
3 packages and 0 specfiles checked; 17 errors, 3 warnings.
# echo 'rpmlint-done:'
Requires
--------
icecat-devel (rpmlib, GLIBC filtered):
/bin/sh
/usr/bin/env
/usr/bin/pkg-config
icecat(x86-64)
ld-linux-x86-64.so.2()(64bit)
libc.so.6()(64bit)
libdl.so.2()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libmozalloc.so()(64bit)
libnspr4.so()(64bit)
libplc4.so()(64bit)
libplds4.so()(64bit)
libpthread.so.0()(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libxul.so()(64bit)
libxul.so(xul24.0)(64bit)
pkgconfig(nspr)
rtld(GNU_HASH)
icecat-static (rpmlib, GLIBC filtered):
icecat (rpmlib, GLIBC filtered):
/bin/bash
/bin/sh
fedora-bookmarks
ld-linux-x86-64.so.2()(64bit)
libX11.so.6()(64bit)
libXext.so.6()(64bit)
libXrender.so.1()(64bit)
libXt.so.6()(64bit)
libasound.so.2()(64bit)
libasound.so.2(ALSA_0.9)(64bit)
libasound.so.2(ALSA_0.9.0rc4)(64bit)
libatk-1.0.so.0()(64bit)
libc.so.6()(64bit)
libcairo.so.2()(64bit)
libdbus-1.so.3()(64bit)
libdbus-glib-1.so.2()(64bit)
libdl.so.2()(64bit)
libevent-2.0.so.5()(64bit)
libffi.so.6()(64bit)
libfontconfig.so.1()(64bit)
libfreetype.so.6()(64bit)
libgcc_s.so.1()(64bit)
libgcc_s.so.1(GCC_3.0)(64bit)
libgcc_s.so.1(GCC_3.3)(64bit)
libgcc_s.so.1(GCC_3.4)(64bit)
libgcc_s.so.1(GCC_4.0.0)(64bit)
libgdk-x11-2.0.so.0()(64bit)
libgdk_pixbuf-2.0.so.0()(64bit)
libgio-2.0.so.0()(64bit)
libglib-2.0.so.0()(64bit)
libgobject-2.0.so.0()(64bit)
libgthread-2.0.so.0()(64bit)
libgtk-x11-2.0.so.0()(64bit)
libhunspell-1.3.so.0()(64bit)
libjpeg.so.62()(64bit)
libjpeg.so.62(LIBJPEG_6.2)(64bit)
libm.so.6()(64bit)
libmozalloc.so()(64bit)
libnspr4.so()(64bit)
libnss3.so()(64bit)
libnss3.so(NSS_3.10)(64bit)
libnss3.so(NSS_3.10.2)(64bit)
libnss3.so(NSS_3.11)(64bit)
libnss3.so(NSS_3.11.1)(64bit)
libnss3.so(NSS_3.11.7)(64bit)
libnss3.so(NSS_3.12)(64bit)
libnss3.so(NSS_3.12.3)(64bit)
libnss3.so(NSS_3.12.9)(64bit)
libnss3.so(NSS_3.13)(64bit)
libnss3.so(NSS_3.2)(64bit)
libnss3.so(NSS_3.3)(64bit)
libnss3.so(NSS_3.4)(64bit)
libnss3.so(NSS_3.5)(64bit)
libnss3.so(NSS_3.6)(64bit)
libnss3.so(NSS_3.7)(64bit)
libnss3.so(NSS_3.9)(64bit)
libnss3.so(NSS_3.9.2)(64bit)
libnss3.so(NSS_3.9.3)(64bit)
libnssutil3.so()(64bit)
libnssutil3.so(NSSUTIL_3.12)(64bit)
libnssutil3.so(NSSUTIL_3.12.3)(64bit)
libnssutil3.so(NSSUTIL_3.13)(64bit)
libpango-1.0.so.0()(64bit)
libpangocairo-1.0.so.0()(64bit)
libpangoft2-1.0.so.0()(64bit)
libpixman-1.so.0()(64bit)
libplc4.so()(64bit)
libplds4.so()(64bit)
libpng16.so.16()(64bit)
libpng16.so.16(PNG16_0)(64bit)
libpthread.so.0()(64bit)
libpulse.so.0()(64bit)
librt.so.1()(64bit)
libsmime3.so()(64bit)
libsmime3.so(NSS_3.13)(64bit)
libsmime3.so(NSS_3.15)(64bit)
libsmime3.so(NSS_3.2)(64bit)
libsmime3.so(NSS_3.3)(64bit)
libsmime3.so(NSS_3.4)(64bit)
libsmime3.so(NSS_3.4.1)(64bit)
libsmime3.so(NSS_3.6)(64bit)
libsmime3.so(NSS_3.9.3)(64bit)
libsqlite3.so.0()(64bit)
libssl3.so()(64bit)
libssl3.so(NSS_3.12.6)(64bit)
libssl3.so(NSS_3.13)(64bit)
libssl3.so(NSS_3.13.2)(64bit)
libssl3.so(NSS_3.14)(64bit)
libssl3.so(NSS_3.2)(64bit)
libssl3.so(NSS_3.4)(64bit)
libstdc++.so.6()(64bit)
libstdc++.so.6(CXXABI_1.3)(64bit)
libvpx.so.1()(64bit)
libxul.so()(64bit)
libxul.so(xul24.0)(64bit)
libz.so.1()(64bit)
nspr
nss
rtld(GNU_HASH)
Provides
--------
icecat-devel:
icecat-devel
icecat-devel(x86-64)
pkgconfig(libxul)
pkgconfig(libxul-embedding)
pkgconfig(mozilla-js)
pkgconfig(mozilla-plugin)
icecat-static:
icecat-static
icecat-static(x86-64)
icecat:
application()
application(icecat-24.0.desktop)
bundled(double-conversion)
bundled(expat)
bundled(graphite2)
bundled(hurfbuzz)
bundled(libogg)
bundled(libtheora)
bundled(libvorbis)
bundled(opus)
bundled(ots)
bundled(python-virtualenv)
bundled(snappy)
bundled(soundtouch)
bundled(xulrunner)
icecat
icecat(x86-64)
libbrowsercomps.so()(64bit)
libbrowsercomps.so(EXPORTED)(64bit)
libdbusservice.so()(64bit)
libdbusservice.so(EXPORTED)(64bit)
libmozalloc.so()(64bit)
libmozgnome.so()(64bit)
libmozgnome.so(EXPORTED)(64bit)
libxul.so()(64bit)
libxul.so(xul24.0)(64bit)
mimehandler(application/vnd.mozilla.xul+xml)
mimehandler(application/xhtml+xml)
mimehandler(text/html)
mimehandler(text/mml)
mimehandler(text/xml)
mimehandler(x-scheme-handler/http)
mimehandler(x-scheme-handler/https)
Unversioned so-files
--------------------
icecat: /usr/lib64/icecat-24.0/browser/components/libbrowsercomps.so
icecat: /usr/lib64/icecat-24.0/components/libdbusservice.so
icecat: /usr/lib64/icecat-24.0/components/libmozgnome.so
icecat: /usr/lib64/icecat-24.0/libmozalloc.so
icecat: /usr/lib64/icecat-24.0/libxul.so
Source checksums
----------------
http://ftp.gnu.org/gnu/gnuzilla/24/icecat-24.0.tar.gz :
CHECKSUM(SHA256) this package :
2a79e6db8831a4047030a0451036a34a97fde455fba7a949efde34052b97bfef
CHECKSUM(SHA256) upstream package :
2a79e6db8831a4047030a0451036a34a97fde455fba7a949efde34052b97bfef
Jar and class files in source
-----------------------------
./icecat-24.0/modules/libjar/test/unit/data/test_bug370103.jar
./icecat-24.0/toolkit/components/search/tests/xpcshell/data/searchTest.jar
./icecat-24.0/toolkit/mozapps/extensions/test/addons/test_chromemanifest_3/inner.jar
./icecat-24.0/toolkit/mozapps/extensions/test/addons/test_install4/addon5.jar
./icecat-24.0/toolkit/mozapps/extensions/test/addons/test_install4/addon7.jar
./icecat-24.0/toolkit/mozapps/extensions/test/addons/test_install4/badaddon.jar
./icecat-24.0/dom/tests/mochitest/dom-level2-html/files/applet2.class
./icecat-24.0/dom/tests/mochitest/dom-level2-html/files/applets/org/w3c/domts/DOMTSApplet.class
./icecat-24.0/dom/tests/mochitest/whatwg/postMessage.jar
./icecat-24.0/content/base/test/file_bug804395.jar
./icecat-24.0/content/base/test/file_CrossSiteXHR_inner.jar
./icecat-24.0/content/html/content/test/bug392567.jar
./icecat-24.0/browser/branding/unofficial/extensions/requestpolicy at requestpolicy.com/chrome/requestpolicy.jar
./icecat-24.0/docshell/test/bug369814.jar
./icecat-24.0/build/mobile/robocop/robotium-solo-3.6.jar
./icecat-24.0/build/mobile/sutagent/android/network-libs/commons-net-ftp-2.0.jar
./icecat-24.0/build/mobile/sutagent/android/network-libs/commons-net-2.0-javadoc.jar
./icecat-24.0/build/mobile/sutagent/android/network-libs/commons-net-2.0-sources.jar
./icecat-24.0/build/mobile/sutagent/android/network-libs/commons-net-2.0.jar
./icecat-24.0/build/mobile/sutagent/android/network-libs/jmdns.jar
./icecat-24.0/xpcom/tests/regorder/extension2.jar
./icecat-24.0/config/tests/test.manifest.jar
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rn icecat-24.0-10.fc20.src.rpm
Buildroot used: fedora-20-x86_64
Active plugins: Python, Shell-api, Generic, Java, C/C++
Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Perl, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Notes:
-----
1) It looks like some Public Domain components present here so you can add
"Public Domain" to license tag;
2) It's worth at least to try to get rid of rpath here;
3) Still unaware of FPC exception for icecat bundled libs;
4) Take into account python and jar notes above;
Also, you can look through the warning list above, and fix issues if
applicable.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list