[Bug 1122208] Review Request: nodejs-agent-base - Turn a function into an `http.Agent` instance

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 23 08:25:22 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1122208

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ mock build is successful for f22

+ rpmlint output on rpms gave
nodejs-agent-base.noarch: W: spelling-error Summary(en_US) http -> HTTP
nodejs-agent-base.noarch: W: spelling-error %description -l en_US http -> HTTP
nodejs-agent-base.noarch: W: spelling-error %description -l en_US async ->
sync, a sync
nodejs-agent-base.noarch: W: only-non-binary-in-usr-lib
nodejs-agent-base.src: W: spelling-error Summary(en_US) http -> HTTP
nodejs-agent-base.src: W: spelling-error %description -l en_US http -> HTTP
nodejs-agent-base.src: W: spelling-error %description -l en_US async -> sync, a
sync
2 packages and 0 specfiles checked; 0 errors, 7 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball    
:a40a7800b1e15cb267ac1f94adeb7586319a14ffecab881bf79e8431723caa46
upstream tarball
:a40a7800b1e15cb267ac1f94adeb7586319a14ffecab881bf79e8431723caa46

+ License "MIT" is valid and is included in its README.md file as %doc

+ rest looks following packaging guidelines


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list