[Bug 1122226] Review Request: nodejs-https-proxy-agent - An HTTP(s) proxy http.Agent implementation for HTTPS

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1122226

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ mock build is successful for f22.

+ rpmlint output on rpms gave
nodejs-https-proxy-agent.noarch: W: spelling-error Summary(en_US) http -> HTTP
nodejs-https-proxy-agent.noarch: W: spelling-error %description -l en_US http
-> HTTP
nodejs-https-proxy-agent.noarch: W: only-non-binary-in-usr-lib
nodejs-https-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/https-proxy-agent/node_modules/agent-base
/usr/lib/node_modules/agent-base
nodejs-https-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/https-proxy-agent/node_modules/extend
/usr/lib/node_modules/extend
nodejs-https-proxy-agent.noarch: W: dangling-symlink
/usr/lib/node_modules/https-proxy-agent/node_modules/debug
/usr/lib/node_modules/debug
nodejs-https-proxy-agent.src: W: spelling-error Summary(en_US) http -> HTTP
nodejs-https-proxy-agent.src: W: spelling-error %description -l en_US http ->
HTTP
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball    
:2929464e9813487c360affafb274f1bc0dded2799c8cd5ddd7c28643468c7e89
upstream tarball
:2929464e9813487c360affafb274f1bc0dded2799c8cd5ddd7c28643468c7e89

+ License "MIT" is valid and is included in its README.md file as %doc

+ rest looks following packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component