[Bug 1121425] Review Request: lazygal - A static web gallery generator

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1121425



--- Comment #4 from Dominik 'Rathann' Mierzejewski <dominik at greysector.net> ---
(In reply to Christopher Meng from comment #3)
> Issues:
> =======
> - Package do not use a name that already exist
>   Note: A package already exist with this name, please check
>   https://admin.fedoraproject.org/pkgdb/acls/name/lazygal
>   See:
>  
> https://fedoraproject.org/wiki/Packaging/
> NamingGuidelines#Conflicting_Package_Names

As stated in the opening description, this is an unretirement review, so the
above doesn't apply.

[...] 
> ----------------------------
> 1. lazygaltest/ may be useful for %check?
> 
> 2. Drop Group tag.

OK.

> 3. You can try RPM soft dependency for f21+:
> 
> Suggest: gstreamer-python

I'll check it.

> I haven't tried, but it's recommended by the upstream.
> 
> 4. Manpages should be listed with a glob 1*/5*.

5. Unbundle javascript in themes/ (thanks, Björn)

* default/SHARED_jquery.js JQuery 1.11 + sizzle.js http://jquery.com/
http://sizzlejs.com/
* inverted/SHARED_plugins.tjs TipTip 1.3
code.drewwilson.com/entry/tiptip-jquery-plugin
* inverted/SHARED_respond.js https://github.com/scottjehl/Respond
* singlepage/SHARED_jquery.colorbox.js Colorbox v1.4.36 -
http://www.jacklmoore.com/colorbox

https://fedoraproject.org/wiki/Packaging:JavaScript

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component