[Bug 1111916] Review Request: golang-github-docker-libcontainer - Configuration options for containers

bugzilla at redhat.com bugzilla at redhat.com
Wed Jul 30 17:26:14 UTC 2014 

https://bugzilla.redhat.com/show_bug.cgi?id=1111916

Marek Goldmann <mgoldman at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #16 from Marek Goldmann <mgoldman at redhat.com> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


ISSUES:

[!]: License file installed when any subpackage combination is installed.

* Please add the LICENSE file to the main package:

%doc LICENSE

OTHER:

* You don't need %defattr in %files section.
* I'm not sure if the %attr for each file is not necessary since this looks for
me as the default. Feel free to leave it as-is.

APPROVED, you can fix the issue at the import time.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated".
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Each %files section contains %defattr if rpm < 4.4
     Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-docker-libcontainer-devel
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: golang-github-docker-libcontainer-1.1.0-4.fc22.x86_64.rpm
          golang-github-docker-libcontainer-devel-1.1.0-4.fc22.x86_64.rpm
          golang-github-docker-libcontainer-1.1.0-4.fc22.src.rpm
golang-github-docker-libcontainer.x86_64: W: spelling-error %description -l
en_US namespaces -> name spaces, name-spaces, names paces
golang-github-docker-libcontainer.x86_64: W: unstripped-binary-or-object
/usr/bin/nsinit
golang-github-docker-libcontainer.x86_64: W: no-documentation
golang-github-docker-libcontainer.x86_64: W: no-manual-page-for-binary nsinit
golang-github-docker-libcontainer.src: W: spelling-error %description -l en_US
namespaces -> name spaces, name-spaces, names paces
golang-github-docker-libcontainer.src: W: spelling-error %description -l en_US
nsinit -> insist
golang-github-docker-libcontainer.src:19: W: unversioned-explicit-provides
nsinit
golang-github-docker-libcontainer.src:65: W: setup-not-quiet
3 packages and 0 specfiles checked; 0 errors, 8 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint golang-github-docker-libcontainer-devel
golang-github-docker-libcontainer
golang-github-docker-libcontainer.x86_64: W: spelling-error %description -l
en_US namespaces -> name spaces, name-spaces, names paces
golang-github-docker-libcontainer.x86_64: W: unstripped-binary-or-object
/usr/bin/nsinit
golang-github-docker-libcontainer.x86_64: W: no-documentation
golang-github-docker-libcontainer.x86_64: W: no-manual-page-for-binary nsinit
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
# echo 'rpmlint-done:'



Requires
--------
golang-github-docker-libcontainer-devel (rpmlib, GLIBC filtered):
    golang
    golang(github.com/syndtr/gocapability/capability)

golang-github-docker-libcontainer (rpmlib, GLIBC filtered):
    libc.so.6()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
golang-github-docker-libcontainer-devel:
    golang(github.com/docker/libcontainer)
    golang(github.com/docker/libcontainer/apparmor)
    golang(github.com/docker/libcontainer/cgroups)
    golang(github.com/docker/libcontainer/cgroups/fs)
    golang(github.com/docker/libcontainer/cgroups/systemd)
    golang(github.com/docker/libcontainer/console)
    golang(github.com/docker/libcontainer/devices)
    golang(github.com/docker/libcontainer/label)
    golang(github.com/docker/libcontainer/mount)
    golang(github.com/docker/libcontainer/mount/nodes)
    golang(github.com/docker/libcontainer/namespaces)
    golang(github.com/docker/libcontainer/netlink)
    golang(github.com/docker/libcontainer/network)
    golang(github.com/docker/libcontainer/nsinit)
    golang(github.com/docker/libcontainer/security/capabilities)
    golang(github.com/docker/libcontainer/security/restrict)
    golang(github.com/docker/libcontainer/selinux)
    golang(github.com/docker/libcontainer/utils)
    golang-github-docker-libcontainer-devel
    golang-github-docker-libcontainer-devel(x86-64)

golang-github-docker-libcontainer:
    golang-github-docker-libcontainer
    golang-github-docker-libcontainer(x86-64)
    nsinit



Source checksums
----------------
https://github.com/docker/libcontainer/archive/v1.1.0.tar.gz :
  CHECKSUM(SHA256) this package     :
992a0a83d8d1df8cb85b3f6c8dd0ee46cc5f4c4cb64690ef5a7c62d697e39ce4
  CHECKSUM(SHA256) upstream package :
992a0a83d8d1df8cb85b3f6c8dd0ee46cc5f4c4cb64690ef5a7c62d697e39ce4


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/bin/fedora-review -m fedora-rawhide-x86_64 -v -b 1111916
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl,
Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

More information about the package-review mailing list