[Bug 1103226] Review Request: antlr32 - ANother Tool for Language Recognition

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1103226



--- Comment #3 from Mat Booth <mat.booth at redhat.com> ---
Thanks for the review.

(In reply to Pete MacKinnon from comment #2)
> MUST:
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/java/antlr32
>

Hmm, I'm not sure why this is reported, the java subpackage should own this. In
the spec file, you should see this:

%files java -f .mfiles-java
%doc tool/LICENSE.txt
%dir %{_datadir}/java/%{name}

The %dir line should expand to /usr/share/java/antlr32

Do you have any thoughts about what is wrong here?


> SHOULD:
> [!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
> It would be nice to have a link to the JIRA where Java 8 patch originated. 
>

Good point, I will add a link to the upstream commit.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component