[Bug 1108765] Review Request: dSFMT - Double precision SIMD-oriented Fast Mersenne Twister

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1108765



--- Comment #2 from Milan Bouchet-Valat <nalimilan at club.fr> ---
Thanks for taking care of this!

I have spotted a few things:
>+LIBDIR     = $(PREFIX)/lib64
Maybe 'lib' would be better, since it does not depend on the architecture.

>+SSE2_LIBDIR = $(LIBDIR)/ss2
Looks like a typo, shouldn't it be '$(LIBDIR)/sse2'?

>+DESTDIR    = .
Shouldn't it be empty instead? The standard behavior is to install to
$(PREFIX).

Also, I think the names of variables should be lower case as standard GNU
variables:
http://www.gnu.org/software/make/manual/html_node/Directory-Variables.html

DESTDIR is apparently uppercase, though.


Finally, have you tried contacting the author? He might be interesting I
applying your patch to make a real shared library upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component