[Bug 483663] Review Request: tetgen - A tetrahedral mesh generator

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=483663



--- Comment #16 from Dominik 'Rathann' Mierzejewski <dominik at greysector.net> ---
Downloaded sources match SRPM:
$ sha256sum tetgen1.5.0.tar.gz 
4d114861d5ef2063afd06ef38885ec46822e90e7b4ea38c864f76493451f9cf3 
tetgen1.5.0.tar.gz

rpmlint:
Checking: tetgen-1.5.0-1.fc20.x86_64.rpm
          tetgen-devel-1.5.0-1.fc20.x86_64.rpm
          tetgen-1.5.0-1.fc20.src.rpm
tetgen.x86_64: W: spelling-error %description -l en_US tetrahedralizations ->
rationalizations, liberalizations
tetgen.x86_64: W: wrong-file-end-of-line-encoding
/usr/share/doc/tetgen/example.poly

Please convert.

tetgen.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libtet.so

It looks like it's getting caught by:
%{_libdir}/libtet.so*

Try using
%{_libdir}/libtet.so.*
instead.

tetgen.x86_64: W: no-manual-page-for-binary tetgen
tetgen-devel.x86_64: W: no-documentation
tetgen.src: W: spelling-error %description -l en_US tetrahedralizations ->
rationalizations, liberalizations
tetgen.src: W: patch-not-applied Patch0: tetgen_cmake.patch
3 packages and 0 specfiles checked; 0 errors, 7 warnings.

The rest seem to be false positives.

Looking at the tetgen-cmake.patch, I notice that you arbitrarily set the SO
version to 1. I suggest starting from 0. Is there a good reason to start from
1?

Also, I don't like it that (almost) the same code is compiled in
/usr/bin/tetgen and in %{_libdir}/libtet.so.* . Is it not possible to patch the
code so that /usr/bin/tetgen is linked against the library?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component