[Bug 1111916] Review Request: golang-github-docker-libcontainer - Configuration options for containers

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1111916



--- Comment #2 from Lokesh Mandvekar <lsm5 at switzerlandmail.ch> ---
(In reply to Vincent Batts from comment #1)
> A couple of items.
> BuildRequires:  golang(github.com/syndtr/gocapability/capability)
> isn't true. There is nothing during this rpmbuild that uses that library.

There's these:
security/capabilities/capabilities.go:   
"github.com/syndtr/gocapability/capability"
types.go:    "github.com/syndtr/gocapability/capability"

> 
> as for runtime Requires:, this is missing:
> * github.com/coreos/go-systemd/dbus
> * github.com/dotcloud/docker/pkg/mount
> * github.com/dotcloud/docker/pkg/symlink
> * github.com/dotcloud/docker/pkg/system
> * github.com/dotcloud/docker/pkg/systemd
> * github.com/dotcloud/docker/pkg/term
> * github.com/dotcloud/docker/pkg/user
> * github.com/godbus/dbus

About the dotcloud/docker ones, won't this introduce cyclic dependencies?
docker-io will be requiring this package as BuildRequires. Or can we get around
that by enforcing NVR requirements
> 
> and github.com/codegangsta/cli when we decide to start building `nsinit`

This was probably cause I hadn't included any tests in %check. There's also Bug
1110497 (but I don't think I checked if that applies to this package). I'll
include tests if they work fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component