[Bug 1074128] Review Request: libserialport - Library for accessing serial ports

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1074128



--- Comment #3 from Alex G. <mr.nuke.me at gmail.com> ---
> (1) [!]: License file installed when any subpackage combination is installed.
> 
> The -doc subpackage does not include a copy of the license.
>
OOOPs. It should depend on the base package. 

> (2) [!]: Package contains no bundled libraries without FPC exception.
> 
> jquery.js is bundled with -doc subpackage.
> 
It seems those new guidelines were rushed out without proper thought and
solutions. I don't know how to kill this unless I kill the -doc subpackage.

> (3) [!]: SourceX tarball generation or download is documented.
>          Note: Package contains tarball without URL, check comments
> 
Sure.

> (4) The tarball has the extension .tar.gz but is actually a zip file.
> 
The git-archive skills are weak with this one (me). Will fix as well.

> (5) Empty "%doc" macro in "%files devel" 
> 
Sure thing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component