[Bug 1074515] Review Request: passenger - Passenger Ruby web application server

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1074515



--- Comment #15 from Jan Kaluža <jkaluza at redhat.com> ---
(In reply to Vít Ondruch from comment #14)
> (In reply to Jan Kaluža from comment #13)
> > > * %{passenger_libdir} into %{_datadir}
> > >   - Isn't the content of %{passenger_libdir} just noarch stuff?
> > 
> > There are some internally used binaries, so it is not noarch. I used
> > %{_datadir} originally, but I had to change that to libdir because of that.
> 
> Could you be more specific please? What does it mean "internally used
> binaries"? Are you speaking about passenger_native_support.so? I can imagine
> it is convenient to have the .so file side by side with the .rb files, since
> you save some issues with managing of load path, but I'd not call it the
> best way.

I can patch the source code to find out passenger_native_support.so from
different directory, but why this is a problem? Where should I put this library
then?

I can probably move *.rb into %{_datadir} and keep just
passenger_native_support.so in %{_libdir}.

There are executable binaries in /usr/lib64/passenger/agents which are executed
by mod_passenger. I can imagine moving them into /usr/libexec probably.

> > > * Is there reason to keep ruby_extension_source in -devel?
> > >   - Aren't the sources kept in -debuginfo?
> > 
> > Passenger is able to compile various nginx versions for Passenger standalone
> > mode. For this functionality, it needs it's source code. I'm not sure about
> > this particular source file. I will ask upstream if it's really needed.
> >
> > > * Object files in passenger/common
> > >   - What is the intention here? Why they are kept in devel package?
> > 
> > As I stated above, they are there to allow passenger to compile nginx (if
> > admin asks Passenger to do it).
> 
> - Is the package really prepared to do so and properly? Where it places the
>   output binaries? Are they placed into proper places, such as /usr/local or
>   /opt?
> - Shouldn't be this functionality split into separate package?
> - Shouldn't we precompile the nginx?

It is prepared. You can execute passenger-install-nginx-module which asks for
the dependencies, the path where to install nginx (/opt/nginx by default),
downloads it and compiles it.

We should not precompile nginx, because we would bundle it, which is not
allowed. I've contacted nginx maintainers to include passenger module into
Fedora's nginx package, but that's not relevant to this review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component