[Bug 1052060] Review Request: ip2location - IP to location library

bugzilla at redhat.com bugzilla at redhat.com
Thu Mar 20 08:27:50 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1052060



--- Comment #12 from Michael Schwendt <bugs.michael at gmx.net> ---
> ip2location provide only the libraries and headers for the application,
> hence no run time package is created. 

This is not acceptable.

The shared library is the runtime part, the headers and libIP2Location.so are
the build-time part.


That's not the only packaging mistake, however. There are more, such as
hardcoded /usr/lib, use of %attr for ordinary +x (prefer %install and fixing
the upstream install code), missing ldconfig scriptlets, missing licensing
files, incorrect license tag, license clarification needed. Just to mention a
few.


Please keep the "Spec URL:" and "SRPM URL:" lines in this ticket up-to-date,
then run "fedora-review -b 1052060" for some helpful reviewing checks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list