[Bug 831929] Review Request: grub-customizer - Grub Customizer is a graphical interface to configure the grub2/burg settings
bugzilla at redhat.com
bugzilla at redhat.com
Wed Mar 26 10:09:13 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=831929
Christopher Meng <cickumqt at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #18 from Christopher Meng <cickumqt at gmail.com> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v3 or later)", "Unknown or generated". 2 files have unknown
license. Detailed output of licensecheck:
GPL (v3 or later)
-----------------
grub-customizer-4.0.4/src/Controller/AboutController.h
grub-customizer-4.0.4/src/Controller/AboutControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/AboutControllerImpl.h
grub-customizer-4.0.4/src/Controller/ControllerAbstract.cpp
grub-customizer-4.0.4/src/Controller/ControllerAbstract.h
grub-customizer-4.0.4/src/Controller/ControllerCollection.h
grub-customizer-4.0.4/src/Controller/EntryEditController.h
grub-customizer-4.0.4/src/Controller/EntryEditControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/EntryEditControllerImpl.h
grub-customizer-4.0.4/src/Controller/EnvEditorController.h
grub-customizer-4.0.4/src/Controller/EnvEditorControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/EnvEditorControllerImpl.h
grub-customizer-4.0.4/src/Controller/ErrorController.h
grub-customizer-4.0.4/src/Controller/ErrorControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/ErrorControllerImpl.h
grub-customizer-4.0.4/src/Controller/GLib/ThreadController.cpp
grub-customizer-4.0.4/src/Controller/GLib/ThreadController.h
grub-customizer-4.0.4/src/Controller/Helper/DeviceInfo.cpp
grub-customizer-4.0.4/src/Controller/Helper/DeviceInfo.h
grub-customizer-4.0.4/src/Controller/InstallerController.h
grub-customizer-4.0.4/src/Controller/InstallerControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/InstallerControllerImpl.h
grub-customizer-4.0.4/src/Controller/MainController.h
grub-customizer-4.0.4/src/Controller/MainControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/MainControllerImpl.h
grub-customizer-4.0.4/src/Controller/SettingsController.h
grub-customizer-4.0.4/src/Controller/SettingsControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/SettingsControllerImpl.h
grub-customizer-4.0.4/src/Controller/ThemeController.h
grub-customizer-4.0.4/src/Controller/ThemeControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/ThemeControllerImpl.h
grub-customizer-4.0.4/src/Controller/ThreadController.h
grub-customizer-4.0.4/src/Controller/Trait/ControllerAware.h
grub-customizer-4.0.4/src/Controller/Trait/ThreadControllerAware.h
grub-customizer-4.0.4/src/Controller/TrashController.h
grub-customizer-4.0.4/src/Controller/TrashControllerImpl.cpp
grub-customizer-4.0.4/src/Controller/TrashControllerImpl.h
grub-customizer-4.0.4/src/Mapper/EntryName.h
grub-customizer-4.0.4/src/Mapper/EntryNameImpl.cpp
grub-customizer-4.0.4/src/Mapper/EntryNameImpl.h
grub-customizer-4.0.4/src/Model/DeviceDataList.cpp
grub-customizer-4.0.4/src/Model/DeviceDataList.h
grub-customizer-4.0.4/src/Model/DeviceDataListInterface.h
grub-customizer-4.0.4/src/Model/DeviceMap.cpp
grub-customizer-4.0.4/src/Model/DeviceMap.h
grub-customizer-4.0.4/src/Model/Entry.cpp
grub-customizer-4.0.4/src/Model/Entry.h
grub-customizer-4.0.4/src/Model/EntryPathBuilder.h
grub-customizer-4.0.4/src/Model/EntryPathBuilderImpl.cpp
grub-customizer-4.0.4/src/Model/EntryPathBuilderImpl.h
grub-customizer-4.0.4/src/Model/EntryPathFollower.h
grub-customizer-4.0.4/src/Model/Env.cpp
grub-customizer-4.0.4/src/Model/Env.h
grub-customizer-4.0.4/src/Model/FbResolutionsGetter.cpp
grub-customizer-4.0.4/src/Model/FbResolutionsGetter.h
grub-customizer-4.0.4/src/Model/Installer.cpp
grub-customizer-4.0.4/src/Model/Installer.h
grub-customizer-4.0.4/src/Model/ListCfg.cpp
grub-customizer-4.0.4/src/Model/ListCfg.h
grub-customizer-4.0.4/src/Model/MountTable.cpp
grub-customizer-4.0.4/src/Model/MountTable.h
grub-customizer-4.0.4/src/Model/Proxy.cpp
grub-customizer-4.0.4/src/Model/Proxy.h
grub-customizer-4.0.4/src/Model/ProxyScriptData.cpp
grub-customizer-4.0.4/src/Model/ProxyScriptData.h
grub-customizer-4.0.4/src/Model/Proxylist.cpp
grub-customizer-4.0.4/src/Model/Proxylist.h
grub-customizer-4.0.4/src/Model/PscriptnameTranslator.cpp
grub-customizer-4.0.4/src/Model/PscriptnameTranslator.h
grub-customizer-4.0.4/src/Model/Repository.cpp
grub-customizer-4.0.4/src/Model/Repository.h
grub-customizer-4.0.4/src/Model/Rule.cpp
grub-customizer-4.0.4/src/Model/Rule.h
grub-customizer-4.0.4/src/Model/Script.cpp
grub-customizer-4.0.4/src/Model/Script.h
grub-customizer-4.0.4/src/Model/ScriptSourceMap.cpp
grub-customizer-4.0.4/src/Model/ScriptSourceMap.h
grub-customizer-4.0.4/src/Model/SettingsManagerData.cpp
grub-customizer-4.0.4/src/Model/SettingsManagerData.h
grub-customizer-4.0.4/src/Model/SettingsStore.cpp
grub-customizer-4.0.4/src/Model/SettingsStore.h
grub-customizer-4.0.4/src/Model/SmartFileHandle.cpp
grub-customizer-4.0.4/src/Model/SmartFileHandle.h
grub-customizer-4.0.4/src/Model/Theme.cpp
grub-customizer-4.0.4/src/Model/Theme.h
grub-customizer-4.0.4/src/Model/ThemeFile.cpp
grub-customizer-4.0.4/src/Model/ThemeFile.h
grub-customizer-4.0.4/src/Model/ThemeManager.cpp
grub-customizer-4.0.4/src/Model/ThemeManager.h
grub-customizer-4.0.4/src/View/About.h
grub-customizer-4.0.4/src/View/ColorChooser.h
grub-customizer-4.0.4/src/View/EntryEditor.h
grub-customizer-4.0.4/src/View/EnvEditor.h
grub-customizer-4.0.4/src/View/Error.h
grub-customizer-4.0.4/src/View/Gtk/About.cpp
grub-customizer-4.0.4/src/View/Gtk/About.h
grub-customizer-4.0.4/src/View/Gtk/Element/List.h
grub-customizer-4.0.4/src/View/Gtk/Element/PartitionChooser.cpp
grub-customizer-4.0.4/src/View/Gtk/Element/PartitionChooser.h
grub-customizer-4.0.4/src/View/Gtk/EntryEditor.cpp
grub-customizer-4.0.4/src/View/Gtk/EntryEditor.h
grub-customizer-4.0.4/src/View/Gtk/EnvEditor.cpp
grub-customizer-4.0.4/src/View/Gtk/EnvEditor.h
grub-customizer-4.0.4/src/View/Gtk/Error.cpp
grub-customizer-4.0.4/src/View/Gtk/Error.h
grub-customizer-4.0.4/src/View/Gtk/Installer.cpp
grub-customizer-4.0.4/src/View/Gtk/Installer.h
grub-customizer-4.0.4/src/View/Gtk/Main.cpp
grub-customizer-4.0.4/src/View/Gtk/Main.h
grub-customizer-4.0.4/src/View/Gtk/Settings.cpp
grub-customizer-4.0.4/src/View/Gtk/Settings.h
grub-customizer-4.0.4/src/View/Gtk/Theme.cpp
grub-customizer-4.0.4/src/View/Gtk/Theme.h
grub-customizer-4.0.4/src/View/Gtk/Trash.cpp
grub-customizer-4.0.4/src/View/Gtk/Trash.h
grub-customizer-4.0.4/src/View/Installer.h
grub-customizer-4.0.4/src/View/Main.h
grub-customizer-4.0.4/src/View/Model/ListItem.h
grub-customizer-4.0.4/src/View/Settings.h
grub-customizer-4.0.4/src/View/Theme.h
grub-customizer-4.0.4/src/View/Trait/ViewAware.h
grub-customizer-4.0.4/src/View/Trash.h
grub-customizer-4.0.4/src/lib/ArrayStructure.cpp
grub-customizer-4.0.4/src/lib/ArrayStructure.h
grub-customizer-4.0.4/src/lib/ContentParser.h
grub-customizer-4.0.4/src/lib/ContentParser/Abstract.cpp
grub-customizer-4.0.4/src/lib/ContentParser/Abstract.h
grub-customizer-4.0.4/src/lib/ContentParser/Chainloader.cpp
grub-customizer-4.0.4/src/lib/ContentParser/Chainloader.h
grub-customizer-4.0.4/src/lib/ContentParser/FactoryImpl.cpp
grub-customizer-4.0.4/src/lib/ContentParser/FactoryImpl.h
grub-customizer-4.0.4/src/lib/ContentParser/Linux.cpp
grub-customizer-4.0.4/src/lib/ContentParser/Linux.h
grub-customizer-4.0.4/src/lib/ContentParser/LinuxIso.cpp
grub-customizer-4.0.4/src/lib/ContentParser/LinuxIso.h
grub-customizer-4.0.4/src/lib/ContentParser/Memtest.cpp
grub-customizer-4.0.4/src/lib/ContentParser/Memtest.h
grub-customizer-4.0.4/src/lib/ContentParserFactory.h
grub-customizer-4.0.4/src/lib/Exception.cpp
grub-customizer-4.0.4/src/lib/Exception.h
grub-customizer-4.0.4/src/lib/FileSystem.cpp
grub-customizer-4.0.4/src/lib/FileSystem.h
grub-customizer-4.0.4/src/lib/Logger.h
grub-customizer-4.0.4/src/lib/Logger/Stream.cpp
grub-customizer-4.0.4/src/lib/Logger/Stream.h
grub-customizer-4.0.4/src/lib/Mutex.h
grub-customizer-4.0.4/src/lib/Mutex/GLib.cpp
grub-customizer-4.0.4/src/lib/Mutex/GLib.h
grub-customizer-4.0.4/src/lib/Trait/ActionLoggerAware.h
grub-customizer-4.0.4/src/lib/Trait/LoggerAware.h
grub-customizer-4.0.4/src/lib/Type.h
grub-customizer-4.0.4/src/lib/assert.cpp
grub-customizer-4.0.4/src/lib/assert.h
grub-customizer-4.0.4/src/lib/csv.cpp
grub-customizer-4.0.4/src/lib/csv.h
grub-customizer-4.0.4/src/lib/md5.cpp
grub-customizer-4.0.4/src/lib/md5.h
grub-customizer-4.0.4/src/lib/regex.cpp
grub-customizer-4.0.4/src/lib/regex.h
grub-customizer-4.0.4/src/lib/str_replace.cpp
grub-customizer-4.0.4/src/lib/str_replace.h
grub-customizer-4.0.4/src/lib/trim.cpp
grub-customizer-4.0.4/src/lib/trim.h
grub-customizer-4.0.4/src/main/gtk-client.cpp
Unknown or generated
--------------------
grub-customizer-4.0.4/src/main/proxy.cpp
grub-customizer-4.0.4/translation/compile_all.sh
[-]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/polkit-1,
/usr/share/polkit-1/actions
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in grub-customizer
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
Rpmlint
-------
Checking: grub-customizer-4.0.4-1.fc21.i686.rpm
grub-customizer-4.0.4-1.fc21.src.rpm
grub-customizer.i686: W: spelling-error %description -l en_US cfg -> cf, cg,
cog
grub-customizer.src: W: spelling-error %description -l en_US cfg -> cf, cg, cog
2 packages and 0 specfiles checked; 0 errors, 2 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint grub-customizer
grub-customizer.i686: W: spelling-error %description -l en_US cfg -> cf, cg,
cog
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
# echo 'rpmlint-done:'
Requires
--------
grub-customizer (rpmlib, GLIBC filtered):
/bin/sh
config(grub-customizer)
grub2
libarchive.so.13
libatk-1.0.so.0
libatkmm-1.6.so.1
libc.so.6
libcairo-gobject.so.2
libcairo.so.2
libcairomm-1.0.so.1
libcrypto.so.10
libcrypto.so.10(libcrypto.so.10)
libgcc_s.so.1
libgcc_s.so.1(GCC_3.0)
libgdk-3.so.0
libgdk_pixbuf-2.0.so.0
libgdkmm-3.0.so.1
libgio-2.0.so.0
libgiomm-2.4.so.1
libglib-2.0.so.0
libglibmm-2.4.so.1
libgobject-2.0.so.0
libgthread-2.0.so.0
libgtk-3.so.0
libgtkmm-3.0.so.1
libm.so.6
libpango-1.0.so.0
libpangocairo-1.0.so.0
libpangomm-1.4.so.1
libsigc-2.0.so.0
libssl.so.10
libstdc++.so.6
libstdc++.so.6(CXXABI_1.3)
libstdc++.so.6(CXXABI_1.3.1)
rtld(GNU_HASH)
Provides
--------
grub-customizer:
application()
application(grub-customizer.desktop)
config(grub-customizer)
grub-customizer
grub-customizer(x86-32)
Source checksums
----------------
https://launchpad.net/grub-customizer/4.0/4.0.4/+download/grub-customizer_4.0.4.tar.gz
:
CHECKSUM(SHA256) this package :
fa54316bddb247857618f7c615b264845acd4f4b2aa9696ba354e7e8756eae22
CHECKSUM(SHA256) upstream package :
fa54316bddb247857618f7c615b264845acd4f4b2aa9696ba354e7e8756eae22
Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -rvn
grub-customizer-4.0.4-1.fc21.R.src.rpm
Buildroot used: fedora-rawhide-i386
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
-----------------------------------------
1. %{buildroot}/ --> %{buildroot}
2. My opinion is that the grub.cfg should be in sourceX but not inlined in the
SPEC as everytime you update the package the timestamp will be changed.
No -p option(worthless if you use EOF)
I just tested this package and it worked pretty well!
Fix above before SCM import.
PACKAGE APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list