[Bug 1081434] Review Request: ip2location - IP2location library

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1081434

Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Whiteboard|                            |NotReady



--- Comment #4 from Michael Schwendt <bugs.michael at gmx.net> ---
> guru2018 2014-03-27 06:05:55 EDT 
> Guru

Please fill in your full name in the bugzilla account preferences.


> SRPM URL: http://www.ip2location.com/rpm/ip2location-c-6.0.3-1.fc17.i686.rpm

That's not a source RPM package.


During package review, if you keep the "Spec URL:" and "SRPM URL:" lines
up-to-date, you can point the fedora-review tool at this ticket and let it
perform many helpful checks:

  fedora-review -b 1081434

Clear the 'NotReady' tag from the ticket's Whiteboard when there is something
to review.


> http://www.ip2location.com/rpm/ip2location-c-6.0.3-1.fc17.i686.rpm

Not repeating the comments on bug 1052060, but listing the package contents
reveals that the /usr/include/IP2Locone directory is not included (and that's
not a thing specific to packaging for Fedora):

$ rpmls -p ip2location-c-6.0.3-1.fc17.i686.rpm 
-rw-r--r--  /usr/include/IP2Loc/IP2Loc_DBInterface.h
-rw-r--r--  /usr/include/IP2Loc/IP2Location.h
-rw-r--r--  /usr/include/IP2Loc/imath.h
lrwxrwxrwx  /usr/lib/libIP2Location.so
lrwxrwxrwx  /usr/lib/libIP2Location.so.1
-rwxr-xr-x  /usr/lib/libIP2Location.so.1.0.0
drwxr-xr-x  /usr/share/doc/ip2location-c-6.0.3
-rw-r--r--  /usr/share/doc/ip2location-c-6.0.3/Developers_Guide.txt
-rw-r--r--  /usr/share/doc/ip2location-c-6.0.3/README

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
 -> https://fedoraproject.org/wiki/Packaging:UnownedDirectories

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component