[Bug 970956] Review Request: clens - A convenience library to aid in porting code from OpenBSD

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=970956



--- Comment #21 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> ---
(In reply to Christopher Meng from comment #20)
> (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #19)
> > 1) For what that trick:
> > cat << EOF > configure
> > #!/bin/bash
> > EOF
> > chmod +x configure
> > %configure
> > ?
> > 
> > Just drop that lines - it looks like a garbage.
> 
> I used to agree with you... But I need to set the building flags properly.

Sure.
You may just export those env variables like:
  CFLAGS="${CFLAGS:-%optflags}" ; export CFLAGS ; 
  CXXFLAGS="${CXXFLAGS:-%optflags}" ; export CXXFLAGS ; 
  LDFLAGS="${LDFLAGS:-%__global_ldflags}"; export LDFLAGS;

Meantime it only c language, so:
make %{?_smp_mflags} CFLAGS="${CFLAGS:-%optflags}"
LDFLAGS="${LDFLAGS:-%__global_ldflags}"
should be full enough.

> > 2) Some files under BSD (2 or 3 clause) and some under ISC. Why you set ISC
> > as license field for package? I think it should be BSD and ISC.
> 
> Please paste the license check results if possible, this package is ISC
> licensed described in README.md.


BSD (2 clause)
--------------
clens-0.7.0/include/clens/sys/tree.h

BSD (3 clause)
--------------
clens-0.7.0/include/clens/glob.h
clens-0.7.0/include/clens/sys/queue.h

BSD (3 clause) ISC
------------------
clens-0.7.0/src/fgetln.c
clens-0.7.0/src/fmt_scaled.c
clens-0.7.0/src/glob.c

BSD (4 clause) ISC
------------------
clens-0.7.0/src/fparseln.c

ISC
---
clens-0.7.0/config/freebsd/build-pkg.sh
clens-0.7.0/config/prep_release.sh
clens-0.7.0/include/clens/clens.h
clens-0.7.0/include/clens/readpassphrase.h
clens-0.7.0/src/arc4random_buf.c
clens-0.7.0/src/arc4random_uniform.c
clens-0.7.0/src/clens.c
clens-0.7.0/src/strlcat.c
clens-0.7.0/src/strlcpy.c
clens-0.7.0/src/strtonum.c
clens-0.7.0/version.sh

Unknown or generated
--------------------
clens-0.7.0/buildver.sh


Is not it available for you??

> > 4) Honestly I've first time review static library. Be aware what according
> > to guideline
> > https://fedoraproject.org/wiki/Packaging:
> > Guidelines#Statically_Linking_Executables you must need citing "The packager
> > must provide rationale for linking statically, including precedences where
> > available, to FESCO for approval."
> > So, as it packaged as dependency to mg (bz#1010897) i strongly encourage you
> > firstly request that exception to do not make useless effort.
> 
> That's for "Statically Linking Executables", means those linked with static
> libraries, but not static libraries itself.

Yes, there I mention mg. It will be intended to be linked with clens
statically. You must request it exception from FESCO. Otherwise it have no
sense to packaging that static lib.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component