[Bug 1087769] Review Request: php-horde-wicked - Wiki application

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1087769

Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pahan at hubbitus.info
           Assignee|nobody at fedoraproject.org    |pahan at hubbitus.info
              Flags|                            |fedora-review?



--- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info> ---
Issues found so far:

1)
php-horde-wicked.src:114: W: mixed-use-of-spaces-and-tabs (spaces: line 10,
tab: line 114)

2)
# ['/usr/bin/yum', '--installroot',
'/var/lib/mock/fedora-rawhide-x86_64/root/', '--releasever', '21', 'install',
'/home/pasha/SOFT/Review/php-horde-wicked/1087769-php-horde-wicked/results/php-horde-wicked-2.0.1-1.fc21.noarch.rpm']
Error: Package: php-horde-wicked-2.0.1-1.fc21.noarch
(/php-horde-wicked-2.0.1-1.fc21.noarch)
           Requires: php-pear(Text_Wiki) < 2.0.0

3)
[!]: Requires correct, justified where necessary.
package.xml have:
  <required>
   <package>
    <name>Text_Wiki</name>
    <channel>pear.php.net</channel>
    <min>1.2.0</min>
   </package>
  </required>

So, no max version should be defined:
Requires:       php-pear(Text_Wiki) >= 1.2.0
Requires:       php-pear(Text_Wiki) <  2.0.0

Requires httpd, mod_php missing.

4)
[!]: Packages should try to preserve timestamps of original installed files.
Please preserve timestamp on package.xml mangled in %prep.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component