[Bug 1161099] Review Request: nodejs-wrappy - Callback wrapping utility

bugzilla at redhat.com bugzilla at redhat.com
Thu Nov 20 05:41:34 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1161099

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
           Assignee|nobody at fedoraproject.org    |panemade at gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> ---
Review:

+ Package built successful in mock (f22 x86_64)

+ rpmlint on generated rpms gave output
nodejs-wrappy.noarch: W: spelling-error %description -l en_US js -> dis, ks, j
nodejs-wrappy.noarch: W: only-non-binary-in-usr-lib
nodejs-wrappy.src: W: spelling-error %description -l en_US js -> dis, ks, j
2 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as (sha256sum)
srpm tarball: 550aad331e605ac0f9ba770096ca8aea7db2cbcb2d24fc16dd6f6848f227c93d
upstream tarball:
550aad331e605ac0f9ba770096ca8aea7db2cbcb2d24fc16dd6f6848f227c93d

+ License is "ISC" and included in its own LICENSE file.

+ follows nodejs packaging guidelines.

Suggestions:
1) line no. 35 contains duplicate %check, remove it.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list