[Bug 1167041] Review Request: nodejs-tern - JavaScript code analyzer for deep, cross-editor language support

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1167041



--- Comment #6 from Tom Hughes <tom at compton.nu> ---
(In reply to Gerard Ryan from comment #5)
> (In reply to Tom Hughes from comment #4)
> > The files in the defs directory should maybe go in
> > %{_datadir} though and then be symlinked into the node library directory.
> 
> Ok, so the files inside defs/ should go directly into %{_datadir}/tern/ and
> then symlinked from there back to %{nodejs_sitelib}/tern/defs/ ?

I think we have generally been using %{_datadir}/%{name} which would be
nodejs-tern rather than tern, but that is the general idea, yes. The actual
guidelines are here:

https://fedoraproject.org/wiki/Packaging:Node.js#Installing_Modules

and just say "arch independent content other than JavaScript code" should be in
%{_datadir}.

> > Also does it make sense to package anything in bin?
> 
> Hmm, actually yes tern, condense, and from_ts from bin/ should probably all
> be packaged. bin/test comes with the module as downloaded from npm...should
> I just include the entire dir?

I would leave out test I think. You may also want to symlink to some of them
from %{_bindir}, especially tern as I think the emacs extensions will need to
be able to start that.

> So, is a subpackage acceptable, or would the main package need to have the
> files & depend on emacs-filesystem? If subpackage, is nodejs-tern-emacs
> acceptable? Or do you know of a way that we could have a subpackage that
> looks like an emacs package, like emacs-tern or something?

I think you're right that case 2 applies and you should require
emacs-filesystem and do it in the main package.

Note you'll need to drop a file (tern-init.el or something) in site-start.d
with the autoload line form http://ternjs.net/doc/manual.html#emacs in it. You
won't need the add-to-list for load-path as /usr/share/emacs/site-lisp will
already be on the path.

> Thanks again for reviewing, and any help you can provide.

No problem. I do have a few node package reviews of my own open if you feel
like reciprocating ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component