[Bug 1162076] Review Request: tuxanci - First tux shooter multiplayer network game

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1162076

Lubomir Rintel <lrintel at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lrintel at redhat.com



--- Comment #2 from Lubomir Rintel <lrintel at redhat.com> ---
(In reply to Mihkel Vain from comment #1)
> Ok.
> 
> A few notes first.
> 
> > Group:          Amusements/Games
> 
> This is not required anymore, unless you plan to target EL5
> 
> > %doc %{_docdir}/tuxanci-%{version}
> 
> I think you should include bundled README, LICENSE and AUTHORS file in doc
> like this:
> 
> > %doc README LICENSE AUTHORS
> 
> No need for %{_docdir}/tuxanci-%{version} under %files section

Why? Upstream install tool copies it there.

> tuxanci.x86_64: E: incorrect-fsf-address
> /usr/share/doc/tuxanci-0.21.0/LICENCE
> 
> https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
> 
> You must inform upstream about that, but I think this is not a blocker
> either.

Done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component