[Bug 1167136] Review Request: python-seaborn - Statistical data visualization in Python

Fri Nov 28 17:10:05 UTC 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1167136

Florian "der-flo" Lehner <dev at der-flo.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+

--- Comment #8 from Florian "der-flo" Lehner <dev at der-flo.net> ---
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 23 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/lib/python3.4/site-packages,
     /usr/lib/python3.4
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib/python3.4/site-packages,
     /usr/lib/python3.4
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
   ---> https://github.com/mwaskom/seaborn/pull/379
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
     python3-seaborn
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
   ---> upstream does not include an license text file
        packager informed upstream and included the license text file as patch
        https://github.com/mwaskom/seaborn/pull/379
        ---> so this is no issue
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=8252351
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

Rpmlint
-------
Checking: python-seaborn-0.5.1-4.fc22.noarch.rpm
          python3-seaborn-0.5.1-4.fc22.noarch.rpm
          python-seaborn-0.5.1-4.fc22.src.rpm
python-seaborn.noarch: E: explicit-lib-dependency python-matplotlib
python-seaborn.noarch: W: spelling-error %description -l en_US matplotlib ->
diplomatic
python-seaborn.noarch: W: spelling-error %description -l en_US statsmodels ->
stats models, stats-models, supermodels
python3-seaborn.noarch: E: explicit-lib-dependency python3-matplotlib
python3-seaborn.noarch: W: spelling-error %description -l en_US matplotlib ->
diplomatic
python3-seaborn.noarch: W: spelling-error %description -l en_US numpy -> bumpy,
lumpy, dumpy
python3-seaborn.noarch: W: spelling-error %description -l en_US scipy -> spicy,
Scipio
python3-seaborn.noarch: W: spelling-error %description -l en_US statsmodels ->
stats models, stats-models, supermodels
python3-seaborn.noarch: W: no-documentation
python-seaborn.src: W: spelling-error %description -l en_US matplotlib ->
diplomatic
python-seaborn.src: W: spelling-error %description -l en_US statsmodels ->
stats models, stats-models, supermodels
3 packages and 0 specfiles checked; 2 errors, 9 warnings.

For the explicit-lib-dependency see
https://bugzilla.redhat.com/show_bug.cgi?id=790869#c2

Rpmlint (installed packages)
----------------------------
# rpmlint python3-seaborn python-seaborn
python3-seaborn.noarch: E: explicit-lib-dependency python3-matplotlib
python3-seaborn.noarch: W: spelling-error %description -l en_US matplotlib ->
diplomatic
python3-seaborn.noarch: W: spelling-error %description -l en_US numpy -> bumpy,
lumpy, dumpy
python3-seaborn.noarch: W: spelling-error %description -l en_US scipy -> spicy,
Scipio
python3-seaborn.noarch: W: spelling-error %description -l en_US statsmodels ->
stats models, stats-models, supermodels
python3-seaborn.noarch: W: no-documentation
python-seaborn.noarch: E: explicit-lib-dependency python-matplotlib
python-seaborn.noarch: W: spelling-error %description -l en_US matplotlib ->
diplomatic
python-seaborn.noarch: W: spelling-error %description -l en_US statsmodels ->
stats models, stats-models, supermodels
2 packages and 0 specfiles checked; 2 errors, 7 warnings.
# echo 'rpmlint-done:'

Requires
--------
python3-seaborn (rpmlib, GLIBC filtered):
    python(abi)
    python3-husl
    python3-matplotlib
    python3-nose
    python3-numpy
    python3-pandas
    python3-scipy
    python3-six

python-seaborn (rpmlib, GLIBC filtered):
    numpy
    python(abi)
    python-husl
    python-matplotlib
    python-nose
    python-pandas
    python-six
    scipy

Provides
--------
python3-seaborn:
    python3-seaborn

python-seaborn:
    python-seaborn

Source checksums
----------------
https://pypi.python.org/packages/source/s/seaborn/seaborn-0.5.1.tar.gz :
  CHECKSUM(SHA256) this package     :
8c8f7f1036cf6155be3d987ee23d2eeeed8c272b0803b32b7d524614f8526688
  CHECKSUM(SHA256) upstream package :
8c8f7f1036cf6155be3d987ee23d2eeeed8c272b0803b32b7d524614f8526688
https://raw.githubusercontent.com/mwaskom/seaborn/master/LICENSE :
  CHECKSUM(SHA256) this package     :
00687272b85470da9e447967b81f9b61b990e6eb4f61ca0b13aab45b083a9a3c
  CHECKSUM(SHA256) upstream package :
00687272b85470da9e447967b81f9b61b990e6eb4f61ca0b13aab45b083a9a3c

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1167136
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

===== Solution =====
      APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component