[Bug 1151843] Review Request: perl-WebService-Dropbox - Perl interface to Dropbox API

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1151843



--- Comment #1 from Petr Šabata <psabata at redhat.com> ---
You're missing some build deps
For running Build.PL:
 - CPAN::Meta, Build.PL:15
 - CPAN::Meta::Prereqs, Build.PL:16
 - File::Basename, Build.PL:13
 - File::Spec, Build.PL:14
 - utf8, Build.PL:10
Then for running the test suite:
 - Data::Dumper, t/05_accessor.t:2, t/10_api.t:2, t/11_range.t:2, t/12_304.t:2
 - Encode, t/05_accessor.t:3, t/10_api.t:3, t/11_range.t:3, t/12_304.t:3
 - File::Temp, t/05_accessor.t:5, t/10_api.t:5, t/11_range.t:5, t/12_304.t:5
 - HTTP::Request, lib/WebService/Dropbox.pm:47 (via import() -> use_lwp())
 - IO::File, t/05_accessor.t:6, t/10_api.t:6, t/11_range.t:6, t/12_304.t:6

Next, unused dependencies which should be removed:
 - IO::Socket::SSL -- not used if Furl is not available

Missing a runtime dependency; this one won't be autodetected:
 - HTTP::Request, lib/WebService/Dropbox.pm:47

The specific perl version BR is rather unnecessary.

Also, filter out all those underspecified dependencies.

Don't repeat the module name in the %description.  Begin it with "A Perl
interface..." or similar instead.  And end it with a period.  Also, consider
including the points from upstream POD description.
http://search.cpan.org/dist/WebService-Dropbox/lib/WebService/Dropbox.pm#DESCRIPTION

Don't package distribution meta files in %doc.  End users have no need for
them.  This includes cpanfile, META.json and minil.toml.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component