[Bug 1149566] Review Request: slurm - Simple LinUx Resource Manager

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1149566

Haïkel Guémar <karlthered at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |karlthered at gmail.com



--- Comment #3 from Haïkel Guémar <karlthered at gmail.com> ---
Few things:
* why is libmad-devel a build requirements for slurm ? I don't see the point in
having a MP3 decoder to build a batch scheduler, and we don't ship libmad
(rpmfusion does) so it's a NO-NO in Fedora. Looks like a typo to me.
Besides, it's inside a conditional that is always false "%if 0"
* All supported Fedora releases (oldest being 19) and EL7 have systemd and
supports systemd macroized scriptlets.
%if 0%{?rhel} && 0%{?rhel} == 6
# sysV stuff
%else
# systemd stuff
%endif
* systemd BR & R are not correct, they should be:
Requires(post): systemd
Requires(preun): systemd
Requires(postun): systemd
BuildRequires: systemd
* subpackages should requires fully versionned base package or other "base"
subpackages
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component