[Bug 1108813] Review Request: python-ZEO - Client-server storage implementation for ZODB
bugzilla at redhat.com
bugzilla at redhat.com
Sat Oct 18 06:18:31 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1108813
Christopher Meng <i at cicku.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #4 from Christopher Meng <i at cicku.me> ---
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 134 files have unknown license. Detailed output
of licensecheck:
Unknown or generated
--------------------
python-ZEO-4.0.0/ZEO-4.0.0/bootstrap.py
python-ZEO-4.0.0/ZEO-4.0.0/release.py
python-ZEO-4.0.0/ZEO-4.0.0/setup.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/ClientStorage.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/Exceptions.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/ServerStub.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/StorageServer.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/TransactionBuffer.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/__init__.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/_compat.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/auth/__init__.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/auth/auth_digest.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/auth/base.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/auth/hmac.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/cache.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/hash.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/interfaces.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/monitor.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/runzeo.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/__init__.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/cache_simul.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/cache_stats.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/parsezeolog.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/tests.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/timeout.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/zeopack.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/zeoqueue.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/zeoreplay.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/zeoserverlog.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/scripts/zeoup.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/Cache.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/CommitLockTests.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/ConnectionTests.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/InvalidationTests.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/IterationTests.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/TestThread.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/ThreadTests.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/__init__.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/auth_plaintext.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/forker.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/servertesting.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/speed.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/stress.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testAuth.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testConfig.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testConnection.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testConversionSupport.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testMonitor.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testTransactionBuffer.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testZEO.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testZEO2.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/testZEOOptions.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/test_cache.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/tests/zeoserver.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/util.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zeoctl.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zeopasswd.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/__init__.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/_hmac.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/client.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/connection.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/error.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/log.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/marshal.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/server.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/smac.py
python-ZEO-4.0.0/ZEO-4.0.0/src/ZEO/zrpc/trigger.py
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 8 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-ZEO
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
-------
Checking: python-ZEO-4.0.0-1.fc22.noarch.rpm
python3-ZEO-4.0.0-1.fc22.noarch.rpm
python-ZEO-4.0.0-1.fc22.src.rpm
python-ZEO.noarch: W: no-manual-page-for-binary runzeo
python-ZEO.noarch: W: no-manual-page-for-binary zeopasswd
python-ZEO.noarch: W: no-manual-page-for-binary zeopack
python-ZEO.noarch: W: no-manual-page-for-binary zeoctl
python3-ZEO.noarch: W: no-manual-page-for-binary zeopack3
python3-ZEO.noarch: W: no-manual-page-for-binary runzeo3
python3-ZEO.noarch: W: no-manual-page-for-binary zeoctl3
python3-ZEO.noarch: W: no-manual-page-for-binary zeopasswd3
3 packages and 0 specfiles checked; 0 errors, 8 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint python3-ZEO python-ZEO
python3-ZEO.noarch: W: no-manual-page-for-binary zeopack3
python3-ZEO.noarch: W: no-manual-page-for-binary runzeo3
python3-ZEO.noarch: W: no-manual-page-for-binary zeoctl3
python3-ZEO.noarch: W: no-manual-page-for-binary zeopasswd3
python-ZEO.noarch: W: no-manual-page-for-binary runzeo
python-ZEO.noarch: W: no-manual-page-for-binary zeopasswd
python-ZEO.noarch: W: no-manual-page-for-binary zeopack
python-ZEO.noarch: W: no-manual-page-for-binary zeoctl
2 packages and 0 specfiles checked; 0 errors, 8 warnings.
# echo 'rpmlint-done:'
Requires
--------
python3-ZEO (rpmlib, GLIBC filtered):
/usr/bin/python3
python(abi)
python3-ZConfig
python3-ZODB
python3-persistent
python3-setuptools
python3-six
python3-transaction
python3-zc-lockfile
python3-zdaemon
python3-zope-interface
python-ZEO (rpmlib, GLIBC filtered):
/usr/bin/python2
python(abi)
python-ZConfig
python-ZODB
python-persistent
python-setuptools
python-six
python-transaction
python-zc-lockfile
python-zdaemon
python-zope-interface
Provides
--------
python3-ZEO:
python3-ZEO
python-ZEO:
python-ZEO
Source checksums
----------------
https://pypi.python.org/packages/source/Z/ZEO/ZEO-4.0.0.tar.gz :
CHECKSUM(SHA256) this package :
63555b6d2b5f98d215c4b5fdce004fb0475daa6efc8b70f39c77d646c12d7e51
CHECKSUM(SHA256) upstream package :
63555b6d2b5f98d215c4b5fdce004fb0475daa6efc8b70f39c77d646c12d7e51
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -rvn python-ZEO-4.0.0-1.fc21.src.rpm
Buildroot used: fedora-rawhide-x86_64
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R,
PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
----------------------------
PACKAGE APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list