[Bug 1150393] Review Request: tengine - A high performance web server and reverse proxy server

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1150393



--- Comment #8 from Jan Kaluža <jkaluza at redhat.com> ---
(In reply to Marcela Mašláňová from comment #6)
> Other sources like 404.html 50x.html contains Powered by nginx. Shouldn't it
> be powered by Tengine?

Yes, I overlooked that, I'll fix that in next SRPM.

> tengine.init contains nginx.conf and calling of nginx, which is probably
> fine, because Fedora will be using tengine.service. Personally, I dislike
> calling binary nginx. There is set a strict conflict with nginx, so it
> should be functionally fine.

I must admit calling the binary differently would be better, but it's upstream
decision to stay binary compatible even when it comes to binary name (so you
can replace nginx with tengine without even rewriting the initscript and so
on).

(In reply to Marcela Mašláňová from comment #6)
> Only man page is called nginx, which doesn't seem right. At least you should
> create link from tengine man page to this nginx.

I will create man-page for "dso_tool" and "tengine" link to "nginx".

> You are missing check section in specfile. Did you think about running tests
> during build time? At least some? They could be conditionalized for running on
> local if it's not possible to run them at koji.

The problem with "make test" is that currently it needs tengine to be installed
to test it. That's not possible to do during RPM creation. I will try to find
out how to persuade that test-framework to test tengine without installing it,
but if I won't success, I will have to follow the way used by nginx package
maintainer - do not run make test during compilation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component