[Bug 1158629] Review Request: tracer - finds outdated running applications in your system

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1158629



--- Comment #3 from Miroslav Suchý <msuchy at redhat.com> ---
Summary should start with capital character.

>%description
>Tracer finds outdated running applications in your system.
>...
Do not repeat Subject in description. Simply remove that first sentence from
description.

> This is plugin for DNF which runs tracer after every successful transaction
Missing dot at the end.

Since Fedora 22 should have python3 as default, it is worth considering to move
to python3. But this is not blocker and can be addressed later.

I talked to Jan Zeleny and it is prefered to call the plugin
"dnf-plugin-tracer".

You do not need to list 
  make
as BuildRequires:
  http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_dpkg.py 0644L /usr/bin/env
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_rules.py 0644L /usr/bin/env
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/resources/router.py 0644L
/usr/bin/python
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_lang.py 0644L /usr/bin/env
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_applications.py 0644L
/usr/bin/env
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_yum.py 0644L /usr/bin/env
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/main.py 0644L /usr/bin/python
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_portage.py 0644L
/usr/bin/env
tracer.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/tracer/tests/test_dnf.py 0644L /usr/bin/env

Either remove shebang, or set the executable flag. But having the file as
non-executable and have there shebang does not have sense.

Otherwise it looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component