[Bug 1125033] Review Request: openstack-manila - OpenStack Shared Filesystem Service

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 1 12:57:00 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1125033



--- Comment #2 from Haïkel Guémar <karlthered at gmail.com> ---
Few remarks:
* provided spec should not be suffixed, it doesn't play well with
semi-automated reviewing tool :)
* changelog entries are not properly formatted, <version>-<revision> should be
appended at the first line of the related entry.
* jquery has been granted a temporary bundling exception but the bundled
version should be cleaned up from windows EOL characters.
* systemd units should installed using macroized scriptlets for F18+ and EL7
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Macroized_scriptlets_.28Fedora_18.2B.29
* about the sudoers configuration, I understand your POV, but I assume that
some sysadmins may want to override either the user or add other commands.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component


More information about the package-review mailing list