[Bug 1136385] Review Request: rubygem-rspec2-mocks - Rspec-2 doubles (mocks and stubs)
bugzilla at redhat.com
bugzilla at redhat.com
Mon Sep 8 10:09:41 UTC 2014
https://bugzilla.redhat.com/show_bug.cgi?id=1136385
--- Comment #3 from Josef Stribny <jstribny at redhat.com> ---
1, Fix spelling:
"Rspec-2 doubles (mocks and stubs)" should be "RSpec 2 doubles (mocks and
stubs)"
"rspec-mocks provides a test-double framework for rspec including support for
method stubs, fakes, and message expectations." should be
"rspec-mocks provides a test-double framework for RSpec including support for
method stubs, fakes, and message expectations."
2, Why do you need two macros for bootstrapping? Isn't need_bootstrap enough?
3, Use single spaces rather than tabs:
"%doc %{gem_instdir}/*.md" should be rather "%doc %{gem_instdir}/*.md"
This is my personal opinion; using tabs looks like it's badly formatted.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
More information about the package-review
mailing list